Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appending the _tmp_shared contents via an earlier hook #441

Merged
merged 4 commits into from
Nov 16, 2018

Conversation

weaverryan
Copy link
Member

@weaverryan weaverryan commented Nov 9, 2018

Fixes #435 and fixes #434

@weaverryan weaverryan changed the title Appending the _tmp_shared contents via an earlier hook [WIP] Appending the _tmp_shared contents via an earlier hook Nov 9, 2018
@weaverryan weaverryan changed the title [WIP] Appending the _tmp_shared contents via an earlier hook Appending the _tmp_shared contents via an earlier hook Nov 9, 2018
This small, internal change was causing the final output code to be
*slightly* different.
@weaverryan weaverryan merged commit 42ec9ef into symfony:master Nov 16, 2018
weaverryan added a commit that referenced this pull request Nov 16, 2018
…erryan)

This PR was squashed before being merged into the master branch (closes #441).

Discussion
----------

Appending the _tmp_shared contents via an earlier hook

Fixes #435 and fixes #434

Commits
-------

42ec9ef Using a static, not random filename for the _tmp_shared entry
c2ba1d6 updating shared-entry-contact-plugin code for emit
fbf6121 removing non-existent method on this hook
5f9d2ee Appending the _tmp_shared contents via an earlier hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant