feat(terser): enable cache and parallelism #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyrkan
approved these changes
Jan 18, 2019
|
Thanks @Kocal! |
Seb33300
reviewed
Mar 6, 2019
| sourceMap: webpackConfig.useSourceMaps | ||
| sourceMap: webpackConfig.useSourceMaps, | ||
| cache: true, | ||
| parallel: true, |
There was a problem hiding this comment.
Is it normal to end the last line with a comma?
There was a problem hiding this comment.
Yes this is allowed in JavaScript (like in TypeScript, Python, PHP...).
However I'm not sure there is a specifing style/linting rule for this on Encore.
See https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Virgules_finales for JavaScript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently Laravel Mix have sped up build time by configuring Terser plugin (laravel-mix/laravel-mix#1925).
I though
cacheandparallelismoptions was already set on encore, but nope.Here a comparaison, before:
and after:
From 16-18 seconds to 14-8 seconds on my machine.
And even if my project does not have a tons of JavaScript, the building time have been reduced.