Add a public method to know whether the runtime is configured #500
Conversation
|
Failure in the job |
|
Once this is merged and released, we can update the recipe to use it by default. |
|
and documentation too. |
|
Thanks for the feature, it will really helps with PhpStorm webpack integration. 👍 Also I've just seen some linting issues. In the whole file, it use |
test/index.js
Outdated
| expect(returnedValue).to.be.true; | ||
| }); | ||
|
|
||
| it ('should return false if the runtime environment has been configured', () => { |
There was a problem hiding this comment.
has been configured -> has not been configured ?
stof
force-pushed
the
is_runtime_configured
branch
from
e8fbcba
to
4ceb39f
Compare
these don't seem to be part of the defined coding standards, as the linting is green on CI. But they are now fixed. |
There was a problem hiding this comment.
Failure in the job Highest versions of the dependencies is unrelated to that change. It looks like the hash of the runtime is different for the new version of webpack (they might have altered their runtime a bit).
Yeah, that one has been failing for a while, not really an issue.
|
should it be marked as an allowed failure then if you don't care about the fact it fail ? That would make the github status more useful. |
|
I don't know if allowing the job to fail is the right solution... it could be a temporary one though. What I meant in my other comment is that it's not important if it fails for that specific reason but it could be for another one. In my opinion the proper way to do it would be to ignore some checks (such as the ones that are based on a hash that we can't control) only when running that job, but I haven't had the time to look into that. |
index.js
Outdated
| @@ -1157,6 +1157,10 @@ class Encore { | |||
| return this; | |||
| } | |||
|
|
|||
| isRuntimeConfigured() { | |||
There was a problem hiding this comment.
Question here: should it be named isRuntimeConfigured or isRuntimeEnvironmentConfigured ? Other methods are taking about RuntimeEnvironment.
There was a problem hiding this comment.
Hmm... now that you point it out I agree that isRuntimeEnvironmentConfigured would probably be better.
stof
force-pushed
the
is_runtime_configured
branch
from
4ceb39f
to
d6ff828
Compare
|
Let's merge it that way, thanks @stof |
This PR was merged into the 3.4 branch. Discussion ---------- feat(encore): IDE Integration This PR add a new entry in the FAQ page of Encore, which explains how to integrate Webpack/Encore in an IDE. Refs: symfony/webpack-encore#236 & symfony/webpack-encore#500 Ping @Lyrkan Let me know if I should modify things, thanks. Commits ------- d8ca065 feat(encore): ide integration
Refs #236