Add extra checks to the copyFiles feature #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyrkan
force-pushed
the
enhanced-copy-files
branch
from
b7e419d
to
eea91a6
Compare
|
WOW! Another deep, difficult bug. Thank you @Lyrkan! |
weaverryan
added a commit
that referenced
this pull request
Jun 16, 2019
This PR was merged into the master branch. Discussion ---------- Add extra checks to the copyFiles feature This PR adds some extra checks to make sure that files *really* match the pattern used in `copyFiles(...)` before the `file-loader` is called (closes #556). For a full description of the issue see #556 (comment), but here is a TL;DR: Currently, if you have a folder that contains a `foo.js` file and calls `copyFile(...)` with a pattern that excludes `.js` files, that file will still be copied. This is caused by the `resolve.extensions` mechanism of Webpack that also applies to `require.context(...)` calls (on which this feature relies) and includes `./foo` (without the extensions) to the list of files that should be imported. Commits ------- eea91a6 Add extra checks to the copyFiles feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some extra checks to make sure that files really match the pattern used in
copyFiles(...)before thefile-loaderis called (closes #556).For a full description of the issue see #556 (comment), but here is a TL;DR:
Currently, if you have a folder that contains a
foo.jsfile and callscopyFile(...)with a pattern that excludes.jsfiles, that file will still be copied.This is caused by the
resolve.extensionsmechanism of Webpack that also applies torequire.context(...)calls (on which this feature relies) and includes./foo(without the extensions) to the list of files that should be imported.