Fixing postcss error: newer versions seem to have a "Syntax Error: name #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyrkan
approved these changes
Nov 17, 2019
Found out why: it was needed when we embedded a patched version of the We could probably remove it safely now and also move |
weaverryan
force-pushed
the
weaverryan-patch-1
branch
from
47f6e99
to
8116e18
Compare
|
Nice research! I did both things - tests pass locally, let's see how if the CI is happy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling PostCSS, but not having a PostCSS config file, we attempt to catch the error so we can print out an example PostCSS file. In a project I just started, this was not happening. It appears that the
e.namewasSyntaxError. Since we're already looking for a very specific error message, I think the name was overkill anyway (though I did check fore.messagejust as an extra sanity check).