Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgraded ts-loader to ^8.0.1 #800

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

skmedix
Copy link
Contributor

@skmedix skmedix commented Jul 7, 2020

Resolves #703

Tests: ✔️ Node 10 | ✔️ Node 12

Copy link
Collaborator

@Lyrkan Lyrkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.0.0 was released a week ago, maybe we should go for that one instead?

Also, should we allow multiple versions instead of only the latest one? This would avoid forcing people to upgrade, especially since 8.0.0 does not seem to be compatible with Typescript 2.x anymore.

@skmedix skmedix closed this Jul 15, 2020
@skmedix skmedix deleted the upgrade/ts-loader branch July 15, 2020 16:59
@skmedix skmedix reopened this Jul 15, 2020
@skmedix skmedix changed the title ⬆️ Upgraded ts-loader to ^7.0.0 ⬆️ Upgraded ts-loader to ^8.0.1 Jul 15, 2020
@stof
Copy link
Member

stof commented Aug 7, 2020

Typescript 2.x anymore

Typescript 2.x is EOLed since years.

@stof stof added the dependencies Pull requests that update a dependency file label Aug 7, 2020
@weaverryan weaverryan changed the base branch from master to main November 18, 2020 18:19
@weaverryan
Copy link
Member

Thanks @skmedix!

@weaverryan weaverryan merged commit 65e2b64 into symfony:main Dec 3, 2020
@NikoGrano
Copy link

@weaverryan @skmedix

Using newer loader will cause encore throw a warning message about using too new version. However this PR doesn't seem to make any other changes than package.json.

Did you double check this will also remove the warning message posted during build?

@Kocal
Copy link
Contributor

Kocal commented Dec 4, 2020

The ts-loader version is enforced in Encore (https://github.com/symfony/webpack-encore/blob/main/lib/features.js#L68), so:

  • if you upgrade Encore and you use ts-loader < 8, you will have a warning message
  • if you upgrade Encore and you already used ts-loader 8, everything will be fine
  • if you upgrade Encore and ts-loader release a new major version (9) and you use it, you will have a warning message (as expected)

@miedzikd
Copy link

miedzikd commented Jun 2, 2021

If I want use new ts-loader version what I should upgrade?
symfony/webpack-encore-bundle composer package or @symfony/webpack-encore npm module? Maybe both?

@weaverryan
Copy link
Member

Actually, ts-loader should directly be in YOUR package.json file, so you can upgrade it directly - that’s all you need :)

@miedzikd
Copy link

miedzikd commented Jun 4, 2021

Thanks @weaverryan for fast response...
Right... I have ts-loader in my package.json... when I upgraded this package to version ^9.2.2 then I see: Webpack Encore requires version ^8.0.0 of ts-loader (...) warning.
My idea was try to upgrade also webpack-encore ... but Im not sure what I should upgrade: composer package or npm module...

But when I think about it now... I can actually update both :) I was just wondering if it enough to update only the npm module, or do I need to update composer package as well.

PS. I love your tutorials ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack Encore requires version ^5.3.0 of ts-loader. Your version 6.2.1 is too new.
9 participants