fixing 2 issues related to webpack-dev-server and HMR #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #931
liveReloadcurrently causes the page to ALWAYS reload: HMR never has a chance to update the content. Disabling by default. This will mean people that currently like the liveReload won't have it anymore unless they re-enable it. But allowing HMR to be broken is not ok. See: [webpack-dev-server] Content base changed. Reloading... #931 (comment)The hostname used for the web socket changed in Webpack 4. For most users it doesn't matter... they use localhost everywhere. But this PR explicitly sets the web socket hostname to the hostname of the dev-server.
TODO: fix/add tests
Cheers!