Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relaxed public path requirements with dev-server #96

Merged
merged 7 commits into from
Jul 21, 2017
Merged

Relaxed public path requirements with dev-server #96

merged 7 commits into from
Jul 21, 2017

Commits on Jul 21, 2017

  1. convert error into warning 

    when using dev-server and an absolute URL for publicPath
to get webpack encore working in docker environment
    @robertfausk @weaverryan
    robertfausk authored and weaverryan committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    910b6bc View commit details
    Browse the repository at this point in the history

  2. convert error into warning 

    test for successful config set when using devServer and setPublicPath
with an absolute URL
    @robertfausk @weaverryan
    robertfausk authored and weaverryan committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    eb5565b View commit details
    Browse the repository at this point in the history

  3. fix issue in generated public path of manifest.json 

    - when using devServer and absolute URL for publicPath
- also add test case
    @robertfausk @weaverryan
    robertfausk authored and weaverryan committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    e206a12 View commit details
    Browse the repository at this point in the history

  4. Reversing some of the changes we won't do for now, and adding the fai… 

    …ling test
    @weaverryan
    weaverryan committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    b27f7c9 View commit details
    Browse the repository at this point in the history

  5. Adding --keep-public-path to dev-server to allow you to fully control… 

    … the publicPath
    @weaverryan
    weaverryan committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    830fdb5 View commit details
    Browse the repository at this point in the history

  6. Allowing an absolute publicPath with dev-server, but showing a warning

    @weaverryan
    weaverryan committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    92e22af View commit details
    Browse the repository at this point in the history

  7. Using real public path, though it doesn't look like it matters

    @weaverryan
    weaverryan committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    4bc1e19 View commit details
    Browse the repository at this point in the history