This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
Error during installation of Version 3.4 with PHP 7.3 #231
Comments
This is the same issue as https://github.com/symfony/symfony-standard/issues/1138 |
fabpot
added a commit
to symfony/symfony
that referenced
this issue
Jun 19, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Debug] workaround BC break in PHP 7.3 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | https://github.com/symfony/symfony-standard/issues/1138 symfony/website-skeleton#231 | License | MIT | Doc PR | - A new warning has been added in PHP 7.3 that is breaking BC with Symfony, since we turn warnings into exceptions. This PR turns the new warning into a deprecation, so that we will be able to remove the added "if" in 5.0. I noticed a few other similar BC breaks in 7.1 and 7.2, but *unless someone reports that they block them*, I don't think we need to care. - 7.1 A non well formed numeric value encountered E_NOTICE - 7.1 A non-numeric value encountered E_WARNING - 7.2 count() now raises a warning when an invalid parameter is passed. See https://github.com/php/php-src/blob/PHP-7.1/UPGRADING + same in upper branches. Commits ------- d8d43e6 [Debug] workaround BC break in PHP 7.3
Fix merged, will work once we tag a new 3.4 release. |
fabpot
added a commit
to symfony/flex
that referenced
this issue
Jun 22, 2019
…e-project & update (nicolas-grekas) This PR was merged into the 1.2-dev branch. Discussion ---------- Merge new "flex-require" section with "require" on create-project & update The goal of this PR is to remove the need for any skeleton-bot as used in https://github.com/symfony/skeleton/pulls?q=is%3Apr+is%3Aclosed+author%3Asymfony-skeleton-bot As a reminder, this bot is currently needed to generate a `composer.lock`. And this file is needed because it's part of a work around to fix a combinatorial explosion when Composer solves dependencies. This PR makes `create-project` a two steps process: first, a skeleton is installed with only flex in "require". When flex is installed and composer enables it, the plugin looks for specific entries in the composer.json file, namely "flex-require" and "flex-require-dev". It merges them with regular "require" and "require-dev", and runs a new "composer update" internally. This also fixes the combinatorial explosion and allows downloading deps in parallel, but it also allows taking the local platform into account - while the current approach with bots forces initial resolution with the minimum supported PHP version. (fixing e.g. symfony/symfony-standard#1138 and symfony/website-skeleton#231 too). Embeds a few fixes found meanwhile. Fixes #450 too. Commits ------- d11742f Merge new "flex-require" section with "require" on create-project & update
this command it's worked |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
During the installation of version 3.4 with PHP 7.3 an error occurs (no problem with PHP 7.2):
The text was updated successfully, but these errors were encountered: