Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 1.8.1 releases triggers a deprecation when ensureKernelShutdown is called with a non-booted kernel #61

Closed
stof opened this issue Sep 8, 2021 · 3 comments · Fixed by #64
Closed

The 1.8.1 releases triggers a deprecation when ensureKernelShutdown is called with a non-booted kernel #61

stof opened this issue Sep 8, 2021 · 3 comments · Fixed by #64
Assignees
@chapterjason

Comments

@stof
Copy link

stof commented Sep 8, 2021

If a kernel has been created but not booted, BaseBundleTestCase::ensureKernelShutdown triggers a deprecation warning when accessing getContainer. Ideally, it should skip the whole logic as the kernel is not booted.

This is especially an issue given that BaseBundleTestCase::bootKernel() starts by calling ensureKernelShutdown
@chapterjason chapterjason self-assigned this Sep 10, 2021
chapterjason added a commit to chapterjason/symfony-bundle-test that referenced this issue Sep 10, 2021
@chapterjason
fix: Skip logic for not booted kernel in ensureKernelShutdown
142249b 
fixes: SymfonyTest#61
@chapterjason chapterjason mentioned this issue Sep 10, 2021
Merged
@chapterjason chapterjason linked a pull request Sep 10, 2021 that will close this issue
fix: Skip logic for not booted kernel in ensureKernelShutdown #64
Merged
Nyholm pushed a commit that referenced this issue Sep 11, 2021
@chapterjason
fix: Skip logic for not booted kernel in ensureKernelShutdown (#64)
0555e48 
* fix: Skip logic for not booted kernel in ensureKernelShutdown

fixes: #61

* ci: Fix phpunit action

* fix: Update baseline
@Nyholm
Copy link
Member

Nyholm commented Sep 11, 2021

Fixed by #64.

Is the 1.x branch ready for a release?

@chapterjason
Copy link
Contributor

@Nyholm Nothing to add from my side, both issues are fixed. 👍🏼

Thank you @stof

@Nyholm
Copy link
Member

Nyholm commented Apr 4, 2022

We just release 2.0, this should all be fixed there.

@Nyholm Nyholm closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chapterjason chapterjason

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Skip logic for not booted kernel in ensureKernelShutdown chapterjason/symfony-bundle-test
3 participants
@stof @Nyholm @chapterjason