Skip to content

Commit

Permalink
[SymForce] Run tests once
Browse files Browse the repository at this point in the history
We've been running all our tests twice in github actions on passing
runs.  `ctest --rerun-failed` runs all the tests if none of the tests
have ever failed.  This should save around 800s on github actions (idk
why symengine_symforce_docs_test is so slow on github actions, possibly
the lower core count).

Tested both the passing and failing cases on github actions
[here](aaron-skydio#3)

Reviewers: bradley,nathan,chao,hayk
Topic: sf-test-once
GitOrigin-RevId: 84eeb36ab9f82350dd73c2a9f3c082a1db6278eb
  • Loading branch information
aaron-skydio committed Jan 7, 2023
1 parent f8f7eb4 commit 4c36881
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,11 @@ jobs:
pip install build/lcmtypes/python2.7
export PYTHONPATH=$PYTHONPATH:$(pwd)
${{ matrix.python }} test/symforce_requirements_test.py --update
ctest --test-dir build -j $(nproc) || true
ctest --test-dir build -j $(nproc) --rerun-failed --output-on-failure
EXIT_CODE=0
ctest --test-dir build -j $(nproc) || EXIT_CODE=$?
if [ $EXIT_CODE -ne 0 ]; then
ctest --test-dir build -j $(nproc) --rerun-failed --output-on-failure
fi
# Upload the docs as an artifact
# To view, download the `docs` artifact from the build and matrix entry you're interested in
Expand Down

0 comments on commit 4c36881

Please sign in to comment.