Warnings are errors for everything

Missed a couple things last time. Ideally we'd have a better way to make sure we have this everywhere Topic: sym-werror-everywhere
symforce-org · Nov 3, 2022 · ec5102f · ec5102f
1 parent 443997a
commit ec5102f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/symforce/benchmarks/CMakeLists.txt b/symforce/benchmarks/CMakeLists.txt
@@ -112,6 +112,10 @@ function(add_matrix_multiplication_benchmark matrix_name)
         matrix_multiplication/gen/matrix_multiplication_benchmark_${matrix_name}.cc
     )
 
+    target_compile_options(matrix_multiplication_benchmark_${matrix_name}
+        PRIVATE ${SYMFORCE_COMPILE_OPTIONS}
+    )
+
     target_link_libraries(
         matrix_multiplication_benchmark_${matrix_name}
         Catch2::Catch2WithMain
@@ -138,6 +142,8 @@ add_executable(
     inverse_compose_jacobian/inverse_compose_jacobian_benchmark.cc
 )
 
+target_compile_options(inverse_compose_jacobian_benchmark PRIVATE ${SYMFORCE_COMPILE_OPTIONS})
+
 find_package(Sophus REQUIRED)
 target_link_libraries(
     inverse_compose_jacobian_benchmark
@@ -159,6 +165,8 @@ add_executable(
     robot_3d_localization/robot_3d_localization_benchmark.cc
 )
 
+target_compile_options(robot_3d_localization_benchmark PRIVATE ${SYMFORCE_COMPILE_OPTIONS})
+
 target_link_libraries(
     robot_3d_localization_benchmark
     gtsam

diff --git a/symforce/examples/bundle_adjustment_in_the_large/CMakeLists.txt b/symforce/examples/bundle_adjustment_in_the_large/CMakeLists.txt
@@ -8,6 +8,8 @@ add_executable(
     bundle_adjustment_in_the_large.cc
 )
 
+target_compile_options(bundle_adjustment_in_the_large_example PRIVATE ${SYMFORCE_COMPILE_OPTIONS})
+
 target_link_libraries(
     bundle_adjustment_in_the_large_example
     symforce_gen

diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
@@ -52,6 +52,7 @@ foreach(SOURCE_FILE ${SYMFORCE_TEST_CC_SOURCES})
   set_target_properties(${TARGET_NAME} PROPERTIES OUTPUT_NAME ${BINARY_NAME})
   set_target_properties(${TARGET_NAME} PROPERTIES TEST_NAME ${TEST_NAME})
   set_target_properties(${TARGET_NAME} PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
+  target_compile_options(${TARGET_NAME} PRIVATE ${SYMFORCE_COMPILE_OPTIONS})
   target_link_libraries(
     ${TARGET_NAME}
     symforce_gen