Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Symbolic integration #379

Closed
ThomasGreenhill opened this issue Jan 4, 2024 · 4 comments
Closed

feat: Symbolic integration #379

ThomasGreenhill opened this issue Jan 4, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@ThomasGreenhill
Copy link

I'd like to use sympy's integrate API, similar to how sympy's diff API is already available through symforce.symbolic.

I'm hoping all that's required is adding a from sympy import integrate and a from symengine import integrate in symbolic.py.

Thanks in advance!

@aaron-skydio
Copy link
Member

SymEngine doesn't have integrate except for series, as far as I can tell (unless they've added it recently). You can use sympy.integrate while using the SymEngine symbolic API the same way you can for sympy.solve, as suggested here: #376 (comment), or you can use sf.sympy.integrate if using the SymPy symbolic API.

This should be easy to add though, like you said it would be as simple as from sympy import integrate when on the SymPy symbolic API, and a wrapper that calls the sympy version when on the SymEngine symbolic API, like we do for limit in symbolic.py.

@aaron-skydio aaron-skydio added the enhancement New feature or request label Jan 4, 2024
@ThomasGreenhill
Copy link
Author

Thanks for the quick response! I can definitely just use sympy integrate for the time being :)

@ThomasGreenhill
Copy link
Author

Thanks a lot for taking care of that, Aaron. Much appreciated.

When will the next symforce release be cut?

@aaron-skydio
Copy link
Member

We're planning to cut a release very soon, probably when numba 0.59 is out (the last of our dependencies to not have py3.12 support)

asa pushed a commit to asa/symforce that referenced this issue Feb 16, 2024
Fixes symforce-org#379

Topic: sf-integrate
Reviewers: brad,nathan,chao,ryan-b
GitOrigin-RevId: 44e95cc2653dfdcb84d2b851ea496010cdc4dbc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants