Skip to content
This repository has been archived by the owner on Jun 16, 2019. It is now read-only.

Commit

Permalink
Note down a future possible improvement to the installer EFI booting
Browse files Browse the repository at this point in the history
  • Loading branch information
hamishcoleman committed Jun 6, 2018
1 parent d964f64 commit 10d6d9f
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,16 @@ $(DISK_IMAGE): size.txt startup.nsh combined.initrd kernel/ubuntu.amd64.kernel
mcopy -i $@.tmp startup.nsh ::
mv $@.tmp $@

# TODO
# - consider adding a EFI shell program to the bootable image?
# This would ensure that the installer was discovered and booted just like
# any other installer, but does require us to download a shell binary from
# somewhere. It also increases the risk that the installer is booted
# accidentally - instead of the intended installed operating system
#
# https://github.com/tianocore/edk2/raw/master/EdkShellBinPkg/FullShell/X64/Shell_Full.efi
# mcopy -i $@.tmp shellx64.efi ::efi/boot/

$(ISO_IMAGE): $(DISK_IMAGE)
xorrisofs \
-o $@ \
Expand Down

0 comments on commit 10d6d9f

Please sign in to comment.