Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancies in examples #24

Open
dandavies99 opened this issue Dec 21, 2021 · 1 comment
Open

Discrepancies in examples #24

dandavies99 opened this issue Dec 21, 2021 · 1 comment

Comments

@dandavies99
Copy link

Related to JOSS review

The examples are excellent - really clear and easy to follow. I encountered just a few problems:

  • mu_vs_mu.calculate() returns a tuple which breaks Surfaces Tutorials 1, 2 and 3 (and the docstring needs updating accordingly).

  • I seem to get a different answer for bulk/Tutorial_4 compared to the plots that are pre-loaded in the notebook. See below for the first example. I'm not sure what the source of the difference could be but might be something you'd like to check.

Screenshot 2021-12-21 at 13 24 41

  • Similar situation for the last plot of bulk/Tutorial_6

Screenshot 2021-12-21 at 13 32 23

@jstse
Copy link
Collaborator

jstse commented Feb 7, 2022

Updated tutorail pictures and should now match the plots you recieved. Issue was old pictures in tutorials not being updated when changing plotting values for examples. See pull request #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants