Solid surfinpy josh #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awvwgk
reviewed
Feb 7, 2022
setup.py
Outdated
| @@ -23,7 +23,8 @@ | |||
| license='MIT license', | |||
| packages=['surfinpy'], | |||
| zip_safe=False, | |||
| install_requires=['scipy', 'numpy', 'jupyter', 'pymatgen', 'numpy', 'matplotlib', 'coverage', 'coveralls', 'seaborn'], | |||
| python_requires='>=3.6', | |||
| install_requires=['scipy', 'numpy', 'jupyter', 'pymatgen', 'numpy', 'matplotlib', 'seaborn','pyyaml'], | |||
There was a problem hiding this comment.
Is jupyter an actual install requirement here (see #22)? Also, you added pandas to list of dependencies in the README, which is indirectly included via seaborn, however shouldn't it be listed explicitly here?
Further the install requirements don't have version constraints, maybe worth adding them if they are in the requirements.txt which is not available via an install from PyPI.
- Removed Pandas from readme - Removed version constraints in install - Updated SciPy constants to use value over depreciated codata.
|
Removed specific versions from requirements.txt. |
This was referenced Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aspire to deal with all pull requests in a timely manner. Please be patient.
Ideally pull requests will respect the underlying intrastructure of surfinpy and agree with PEP8, etc. However, please do not let this put novice programmers off contributing as we will do everything we can to help.