Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tabs in default tt2 templates + some indentation changes #352

Merged
merged 1 commit into from Jun 30, 2018

Conversation

Projects
None yet
3 participants
@ldidry
Copy link
Contributor

ldidry commented Jun 23, 2018

I recently updated my Sympa and thus dived in the templates to update my changes. I saw a lot of tab indentation mixed with spaces indentation, which make templates hard to read if your tab width setting is not the one used by the writer of the template (and the tab width is not always the same accross the different templates).

So I removed all tabs and replaced them by spaces. I also made indentation improvments in some templates (not all: it would be a huge work, I may do it in a second time).

If you do a git diff --ignore-all-space on my commit, you'll see that I didn't touch much real code (I replaced some tags that were in caps, small things like that).

@xavierba

This comment has been minimized.

Copy link
Contributor

xavierba commented Jun 28, 2018

The non-whitespace changes are indeed very few and look sane. Should be good to merge.

@ikedas ikedas merged commit 6864055 into sympa-community:sympa-6.2 Jun 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.