Refactor internals of config (1) #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikedas
force-pushed
the
refactor_robot_config_trial-4
branch
from
b4843d8
to
d5f5ecb
Compare
…dy up the source.
ikedas
force-pushed
the
refactor_robot_config_trial-4
branch
from
d5f5ecb
to
8247a42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first phase of refactoring. The final goal is improving the code to manipulate list/domain/site configuration in uniform method.
On this phase configuration schema of list (
config), domain (robot.conf) and site (sympa.conf) are unified. Now a parameter of a list and its default on domain/site internally use the same name.