Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Composer Autoload #15

Merged
merged 1 commit into from Jan 14, 2016
Merged

Require Composer Autoload #15

merged 1 commit into from Jan 14, 2016

Conversation

bernardodiasc
Copy link
Contributor

This fix is necessary to work with Symphony 2.6.
Cheers.

@nitriques
Copy link
Member

Yes but it breaks 2.5 compatibility... And I am not sure on how to deal with this.

The easiest thing would be to create version 2.0, making it only compatible with 2.6.

Or we could create code that check if the autoload file exists.

Maybe a try... catch would work ?

cc @brendo How did we (or should we) deal with this ?

@nitriques nitriques self-assigned this Jun 14, 2015
@nitriques nitriques merged commit 5c720a3 into symphonists:master Jan 14, 2016
@nitriques
Copy link
Member

I've managed to make it compatible with 2.4 and 2.5 in 6e56c97

Released in 1.4.0

@bernardodiasc
Copy link
Contributor Author

awesome! thanks man! :)

@nitriques
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants