Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function footprint of displayPublishPanel is missing the entry ID #10

Closed
michael-e opened this issue Oct 26, 2015 · 4 comments
Closed

Function footprint of displayPublishPanel is missing the entry ID #10

michael-e opened this issue Oct 26, 2015 · 4 comments
Assignees
@nitriques
Labels
Fixed in integration
Milestone
Version 1.1.0

Comments

@michael-e
Copy link
Member

Currently we have:

public function displayPublishPanel(&$wrapper, $data = null, $error = null, $prefix = null, $postfix = null)

But it should be:

public function displayPublishPanel(XMLElement &$wrapper, $data = null, $flagWithError = null, $fieldnamePrefix = null, $fieldnamePostfix = null, $entry_id = null)

So:

  • it's missing the entry ID currently
  • parameter names should ideally be the same as in Symphony's lib/toolkit/class.field.php

The proposed change would also fix #9.
@michael-e michael-e mentioned this issue Oct 26, 2015
Closed
@nitriques nitriques self-assigned this Oct 28, 2015
@nitriques
Copy link
Member

This is some pretty old code d966357 almost 4 years ago!

BTW both fields have this problem. I can't believe I've ship this so many times and nobody complained.

@nitriques
Copy link
Member

I like the 'footprint' idea! :) It's actually the method's signature :P

nitriques added a commit that referenced this issue Dec 6, 2015
@nitriques
Fixed displayPublishPanel signature
2947b45 
This makes the parameters names exactly like the core ones and adds the
$entry_id parameter.

Fixes #10
@michael-e
Copy link
Member Author

:-)

@nitriques
Copy link
Member

Sorry I had to rebase ... But it's fixed now!

@nitriques nitriques modified the milestone: Version 1.1.0 Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nitriques nitriques

Labels
Fixed in integration
Projects
None yet
Milestone
Version 1.1.0
Development

No branches or pull requests
2 participants
@michael-e @nitriques