Issue with caching and original image being returned

[nickdunn]

See http://symphony-cms.com/discuss/thread/74805/

[michael-e]

Approved. Looks like a cache request delivers the original image instead of the cached one. (The cached image is correct.)

[nickdunn]

Could it be:
b4b19fd

[michael-e]

I guess you nailed it.

It's hard to understand the logic here, it's rather weird. I think @klaftertief was tricked by

if($param->mode == MODE_NONE){

which at this point probably means that there is "no need to do any (new) processing on the image". It does not mean that there has been no mode set in the request.

[michael-e]

@klaftertief: Can you please check the mentioned commit and give us some feedback?

[klaftertief]

Yep, @michael-e is right with his explanation. When images are read from the cache (server side) $param->mode is set to MODE_NONE. So the commit above should be reverted. This means, that the direct display mode is broken. Can you confirm this?

Sorry for the inconvenience.

[michael-e]

Pull request sent (see above).

Yes, the direct display mode is broken. As soon as somebody found the time to fix this, we must change the submodule reference in the Symphony repo (and maybe release a new version?).

[brendo]

So is this issue is 'closed' by the above pull request and #15 is a new issue?

[michael-e]

Correct.