Removes empty parent association sections from associations drawer #2741
Conversation
jensscherbl
requested review from
nilshoerrmann,
michael-e,
brendo and
nitriques
|
Looks like sections without actual associations weren't listed in the "linked to"-part of the association drawer before 2.7.0 and I guess this change more or less "happened" while refactoring the drawer and wasn't really introduced by purpose. So I'm all for Jens' proposal and remove these links in the next patch-release again. |
|
@twiro Thanks for the detailed feedback, much appreciated. |
|
The goal was to add information about the possible links. Without it, you loose information about all the possible associations. It is also weird to have empty sections in one way, but not the other way around. I do not know if that fact comes from our data modelling. But I sure do know that Symphony should not care about one's data modelling, so I am tempted to add "Yet Another Configuration Setting"TM. I'll think about it, but with 4 votes against 1 right now, you guys might expect me to merge it in the next few days ;) |
The difference is that having it for the other direction offers additional functionality because of the “new” button. |
Yeah I understand that ;) Still feels weird to me! |
|
Well, even @alexnantel88 is for it, so I guess democracy wins. This time ;) |
I find the empty parent association sections in the redesigned associations drawer quite noisy since the 2.7.0-release (see screenshots). As far as I can tell, they also provide no real value, so I propose to remove them entirely. Not sure if this is something that should be changed in a patch release or better be cherry-picked for the 3.0.x-branch, but I’m working with the 2.7.0-code at the moment, therefore submitting this to the 2.7.x-branch.