Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizeable templates #866

Closed
nils-werner opened this issue Oct 26, 2011 · 5 comments
Closed

Customizeable templates #866

nils-werner opened this issue Oct 26, 2011 · 5 comments

Comments

@nils-werner
Copy link
Contributor

Spurred by a thread on the forum I went ahead and implemented a template-overloading system for 2.4. It enables developers to copy any of the templates in symphony/template/ into workspace/template/ and modify them to their needs. May it be a custom fatal error page style or custom DataSource skeleton, any of the templates can be changed.

The commits to implement this feature are in my templates branch. What do you think, is this a feature we even wanted?

@allen
Copy link
Contributor

allen commented Oct 27, 2011

Yep, this is great to have. It's something we implemented in the-version-formerly-known-as-S3 (but not widely known) and it's great to see this functionality introduced in S2.

@brendo
Copy link
Member

brendo commented Dec 8, 2011

@nils-werner, this is a pretty safe addition to the core, and it adds a lot of flexibility. Did you want to submit a PR for 2.3 now that the template naming updates have been committed?

@nils-werner
Copy link
Contributor Author

I've just rebased that branch.

It's working for me again but could you please have a second look if I made any mistakes as it was quite merge conflict-heavy?

@brendo
Copy link
Member

brendo commented Dec 14, 2011

Thanks for rebasing, makes it much clearer! It looks like you've got most, I'll pull in a give a more thorough testing before merging. Thanks again!

@brendo
Copy link
Member

brendo commented Dec 16, 2011

Pulled, updated, merged, pushed. Thanks!

@brendo brendo closed this as completed Dec 16, 2011
brendo referenced this issue Apr 1, 2014
…PHONY_URL so that assets can be resolved. Closes #1948
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants