-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizeable templates #866
Comments
Yep, this is great to have. It's something we implemented in the-version-formerly-known-as-S3 (but not widely known) and it's great to see this functionality introduced in S2. |
@nils-werner, this is a pretty safe addition to the core, and it adds a lot of flexibility. Did you want to submit a PR for 2.3 now that the template naming updates have been committed? |
I've just rebased that branch. It's working for me again but could you please have a second look if I made any mistakes as it was quite merge conflict-heavy? |
Thanks for rebasing, makes it much clearer! It looks like you've got most, I'll pull in a give a more thorough testing before merging. Thanks again! |
Pulled, updated, merged, pushed. Thanks! |
Spurred by a thread on the forum I went ahead and implemented a template-overloading system for
2.4
. It enables developers to copy any of the templates insymphony/template/
intoworkspace/template/
and modify them to their needs. May it be a custom fatal error page style or custom DataSource skeleton, any of the templates can be changed.The commits to implement this feature are in my
templates
branch. What do you think, is this a feature we even wanted?The text was updated successfully, but these errors were encountered: