Update field.upload.php #2747
Closed
Update field.upload.php #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SVG image support
michael-e
reviewed
Sep 5, 2017
| @@ -15,7 +15,8 @@ class FieldUpload extends Field implements ExportableField, ImportableField | |||
| 'image/jpeg', | |||
| 'image/pjpeg', | |||
| 'image/png', | |||
| 'image/x-png' | |||
| 'image/x-png', | |||
| 'image/svg+xml' | |||
There was a problem hiding this comment.
Please do not use tabs to indent code. Use spaces.
|
Just to make everyone aware, there’s discussion about this regarding potential security concerns. From what I recall, the issue is that an SVG could contain JavaScript that would be automatically executed by browsers. See w3c/svgwg#266 and Active Content Injection with SVG Files. |
|
@jensscherbl is right. I do not want that in the core. If you want to be able to use it @byura I would recommend using a custom validator file: manifest/validators.php. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SVG image support