Skip to content

Commit

Permalink
Removed unecessary div. qualifier
Browse files Browse the repository at this point in the history 
It's redundant and totally not needed.
Reduces possible reuse.
  • Loading branch information
@nitriques
nitriques committed Jun 21, 2016
1 parent 9c8679f commit 5b9e33c
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 15 deletions.
11 changes: 5 additions & 6 deletions symphony/assets/css/src/admin.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ fieldset.settings.highlight {
right: 0;
}

div.password {
.password {
position: absolute;
left: 0;
box-sizing: border-box;
Expand All @@ -479,8 +479,7 @@ div.password {
}

@media screen and (max-width: 700px) {

div.password {
.password {
padding: 0;
}
}
Expand Down Expand Up @@ -607,15 +606,15 @@ ul.page form span {

/* Checkboxes */

div.field-checkbox {
.field-checkbox {
min-height: 1.6rem;
}

div.field-checkbox:first-child {
.field-checkbox:first-child {
margin-top: 2rem;
}

div.field-checkbox + .field:not(.field-checkbox) {
.field-checkbox + .field:not(.field-checkbox) {
margin-top: 2.6rem;
}

Expand Down
18 changes: 9 additions & 9 deletions symphony/assets/css/src/symphony.drawers.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,17 @@
Horizontal drawers
-----------------------------------------------------------------------------*/

div.drawer.horizontal {
.drawer.horizontal {
position: relative;
}

div.drawer.horizontal .contents {
.drawer.horizontal .contents {
margin-top: 1.7rem;
padding: 2rem 0;
border-top: 0.1rem solid rgba(0, 0, 0, 0.05);
}

div.drawer.horizontal .contents:after {
.drawer.horizontal .contents:after {
content: ' ';
display: block;
clear: both;
Expand All @@ -37,8 +37,8 @@ div.drawer.horizontal .contents:after {
/**
* Height is set implicitly via `top` and `bottom` to allow for dynamic height.
*/
div.drawer.vertical-left,
div.drawer.vertical-right {
.drawer.vertical-left,
.drawer.vertical-right {
position: absolute;
top: 0;
bottom: 0;
Expand All @@ -48,17 +48,17 @@ div.drawer.vertical-right {
background: #f4f4f4;
}

div.drawer.vertical-left {
.drawer.vertical-left {
left: 0;
border-right: 0.1rem solid rgba(0, 0, 0, 0.05);
}

div.drawer.vertical-right {
.drawer.vertical-right {
right: 0;
border-left: 0.1rem solid rgba(0, 0, 0, 0.05);
}

div.drawer.vertical-left .contents,
div.drawer.vertical-right .contents {
.drawer.vertical-left .contents,
.drawer.vertical-right .contents {
padding: 2rem;
}

10 comments on commit 5b9e33c

@animaux
Copy link
Contributor

@animaux animaux commented on 5b9e33c Mar 21, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the div.drawer.*-part this results in a css clash with the documenter-button and possibly other drawer-triggering-buttons. See here.

@nitriques
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it for all selectors or some specific one ? Sorry about that BTW.

@animaux
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries :)

Regarding documenter the drawer button has class="button drawer vertical-right".

@nitriques
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what does the association drawer has ?

@animaux
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same sans button: class="drawer vertical-right". Difference is <a> vs. <div> or the parent #context vs. #content.

@nitriques
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both great possible solutions... more on this tomorrow !

@nitriques
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll tackle this on Friday finally.

@nitriques
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On wednesday :( sorry

@animaux
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries.

@nitriques
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7f149964 :)

Please sign in to comment.