Beginnings of changes for PHP 5.4 support #1042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…singPageIdentifier` for PHP 5.4 (and good API design).
|
I've merged locally and can confirm that there are no ill effects from these changes in a PHP5.3 install. I'll leave the PR open to collect any future commits. |
|
Just ignore this request — I'll create a new one that doesn't contain my dodgy merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of places where PHP 5.4 seems a lot stricter than earlier versions. Personally, I see this as a good thing — it's exposing places where our API design is quite ambiguous (and could potentially have undefined behaviour).
There'll be plenty more changes like this, but this change set got the major screens functioning.
These changes have not been tested for backwards compatibility with PHP 5.3, so please don't merge until this has been confirmed.
Partially addresses #1041.