Fix naming of OpenFin and JavaScript, Reorganise notification template

symphonyoss · Mar 10, 2017 · 82940cc · 82940cc
1 parent d42fc9c
commit 82940cc
Show file tree

Hide file tree

Showing 8 changed files with 37 additions and 24 deletions.
diff --git a/packages/api-openfin-demo/README.md b/packages/api-openfin-demo/README.md
@@ -1,6 +1,6 @@
-# Symphony API for Openfin Demo
+# Symphony API for OpenFin Demo
 
-This project provides a demonstration of the Symphony Desktop Wrapper API within Openfin.
+This project provides a demonstration of the Symphony Desktop Wrapper API within OpenFin.
 
 ## Usage
 

diff --git a/packages/api-openfin-demo/app.json b/packages/api-openfin-demo/app.json
@@ -16,4 +16,4 @@
         "description": "",
         "name": "SSF API Demo Openfin"
     }
-}
+}
diff --git a/packages/api-openfin-demo/package.json b/packages/api-openfin-demo/package.json
@@ -11,8 +11,6 @@
  "author": "",
  "license": "Apache-2.0",
  "dependencies": {
-   "bootstrap": "^3.3.7",
-   "jquery": "^3.1.1",
    "openfin-cli": "^1.1.5",
    "ssf-desktop-api-specification": "0.0.1",
    "ssf-desktop-api-openfin": "0.0.1"

diff --git a/packages/api-openfin/.eslintrc.json b/packages/api-openfin/.eslintrc.json
@@ -0,0 +1,5 @@
+{
+  "globals": {
+    "fin": true
+  }
+}
diff --git a/packages/api-openfin/README.md b/packages/api-openfin/README.md
@@ -1,13 +1,13 @@
-# Symphony API for Openfin
+# Symphony API for OpenFin
 
-This project provides an implementation of the Symphony Desktop Wrapper API Specification for Openfin
+This project provides an implementation of the Symphony Desktop Wrapper API Specification for OpenFin
 
 ## Usage
 
-Add this package to your openfin project:
+Add this package to your OpenFin project:
 
 ```
 npm install ssf-desktop-api-openfin --save
 ```
 
-You need to include this code into the project by loading the javascript file directly (as Openfin does not support preloading).
+You need to include this code into the project by loading the JavaScript file directly (as OpenFin does not support preloading).
diff --git a/packages/api-openfin/index.js b/packages/api-openfin/index.js
@@ -1,8 +1,6 @@
-/* globals fin  */
 window.Notification = function(title, options) {
   const message = {
-    title: title,
-    options: options
+    title: title
   };
 
   // eslint-disable-next-line no-new

diff --git a/packages/api-openfin/notification.html b/packages/api-openfin/notification.html
@@ -1,11 +1,23 @@
-<h5 id="message">Message</h5>
-<script>
-  function onNotificationMessage(message) {
-    document.getElementById('message').innerText = message.title;
-  }
-</script>
-<style>
-  html {
-    border: solid 2px black;
-  }
-</style>
+<!DOCTYPE html>
+<head>
+  <meta charset="utf-8">
+  <title></title>
+  <style>
+    html {
+      border: solid 2px black;
+      position: fixed;
+      top: 0px;
+      left: 0px;
+      right: 0px;
+      bottom: 0px;
+    }
+  </style>
+</head>
+<body>
+  <h5 id="message"></h5>
+  <script>
+    function onNotificationMessage(message) {
+      document.getElementById('message').innerText = message.title;
+    }
+  </script>
+</body>
diff --git a/packages/api-specification/src/index.js b/packages/api-specification/src/index.js
@@ -1 +1 @@
-// Intentionally blank, overridden by openfin to access API
+// Intentionally blank, overridden by OpenFin to access API