This repository has been archived by the owner on Sep 7, 2018. It is now read-only.
Add method to get window by id #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-lee-eng
approved these changes
Jul 12, 2017
packages/api-openfin/src/window.ts
Outdated
|
|
||
| let app = null; | ||
| let existsPromise: Promise<void>; | ||
| if (id.match(new RegExp(idRegex))) { |
There was a problem hiding this comment.
I think this could be improved by having a branch to determine the app id, then then separately doing the appExists -> wrap code (i.e. not having to duplicate that code).
There was a problem hiding this comment.
Yeah good idea. Thanks!
|
@DevAndyLee Refactored and remove the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on the work that @kirilpopov did in #171 (see method). Currently just uses a static method on the window class, but we could move this into a separate class (like the initial PR) if necessary.