Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #14 : Configurable output #15

Closed
wants to merge 5 commits into from

Conversation

jeremp
Copy link

@jeremp jeremp commented Oct 12, 2017

I've started working on the #14 issue.

I introduced two PrintStreams initialized by default to System.out and System.err.
I replaced the references to System.out and System.err to the correct PrintStream.

I've seen that error output was used most of the time to display stuffs that, in my opinion, are not errors (request and response headers, response body, ... ).
I think we could change it to use the standard output.

I thing printUsage() and printConfigSample() should keep on using System.out

@ghost
Copy link

ghost commented Oct 12, 2017

Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have you on file. In order for us to review and merge your code, please follow the directions at the link above. If you have questions or believe you've received this message in error, don't hesitate to contact Maurizio Pillitu (@maoo on github), our Devops Director.

CLA has not been signed by users @jeremp, @jeremp

@ldrozdz
Copy link
Contributor

ldrozdz commented Oct 12, 2017

Closing due to CLA issues. Will reopen once those are resolved.

@ldrozdz ldrozdz closed this Oct 12, 2017
@ldrozdz ldrozdz reopened this Nov 30, 2017
@ghost ghost added the cla-signed label Nov 30, 2017
@linux-foundation-easycla
Copy link

CLA Not Signed

@ldrozdz ldrozdz changed the title WIP - Issue #14 : Configurable output Issue #14 : Configurable output Nov 24, 2022
@ldrozdz
Copy link
Contributor

ldrozdz commented Nov 24, 2022

Reopening as #15 to fix CLA issues.

@ldrozdz ldrozdz closed this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants