add test for adapter connection

symphonyoss · Jul 24, 2016 · 0efa499 · 0efa499
1 parent e0e6404
commit 0efa499
Show file tree

Hide file tree

Showing 2 changed files with 68 additions and 14 deletions.
diff --git a/src/adapter.coffee b/src/adapter.coffee
@@ -36,34 +36,45 @@ class SymphonyAdapter extends Adapter
     @robot.logger.debug "Reply"
     @send(envelope, strings)
 
-  run: ->
+  run: =>
     @robot.logger.info "Initialising..."
     @symphony = new Symphony(process.env.HUBOT_SYMPHONY_HOST, process.env.HUBOT_SYMPHONY_PRIVATE_KEY, process.env.HUBOT_SYMPHONY_PUBLIC_KEY, process.env.HUBOT_SYMPHONY_PASSPHRASE)
     @symphony.whoAmI()
       .then (response) =>
         @symphony.getUser(response.userId)
         .then (response) =>
+          @robot.displayName = response.userAttributes?.displayName
           @robot.logger.info "Connected as #{response.userAttributes?.displayName} [#{response.userSystemInfo?.status}]"
       .fail (err) =>
         @robot.emit 'error', new Error("Unable to resolve identity: #{err}")
     @symphony.createDatafeed()
       .then (response) =>
         @robot.logger.info "Created datafeed: #{response.id}"
+        this.on 'poll', @_pollDatafeed
         @emit 'connected'
-        this.on 'poll', () =>
-          @robot.logger.debug "Polling datafeed #{response.id}"
-          @symphony.readDatafeed(response.id)
-            .then (response) =>
-              if response?
-                @robot.logger.debug "Received #{response.length} datafeed messages"
-                @_receiveMessage msg for msg in response when msg.v2messageType = 'V2Message'
-              @emit 'poll', response.id
-            .fail (err) =>
-              @robot.emit 'error', new Error("Unable to read datafeed #{response.id}: #{err}")
-        @emit 'poll'
+        @robot.logger.debug "'connected' event emitted"
+        @emit 'poll', response.id
+        @robot.logger.debug "First 'poll' event emitted"
       .fail (err) =>
         @robot.emit 'error', new Error("Unable to create datafeed: #{err}")
 
+  close: =>
+    @robot.logger.debug 'Removing datafeed poller'
+    this.removeListener 'poll', @_pollDatafeed
+
+  _pollDatafeed: (id) =>
+    # defer execution to ensure we don't go into an infinite polling loop
+    process.nextTick =>
+      @robot.logger.debug "Polling datafeed #{id}"
+      @symphony.readDatafeed(id)
+        .then (response) =>
+          if response?
+            @robot.logger.debug "Received #{response.length} datafeed messages"
+            @_receiveMessage msg for msg in response when msg.v2messageType = 'V2Message'
+          @emit 'poll', id
+        .fail (err) =>
+          @robot.emit 'error', new Error("Unable to read datafeed #{id}: #{err}")
+
   _receiveMessage: (message) =>
     @symphony.getUser(message.fromUserId)
       .then (response) =>

diff --git a/test/adapter-test.coffee b/test/adapter-test.coffee
@@ -14,13 +14,56 @@
 #    limitations under the License.
 #
 
+EventEmitter = require 'events'
 assert = require('chai').assert
 SymphonyAdapter = require '../src/adapter'
+NockServer = require './nock-server'
+
+nock = new NockServer('https://foundation-bot.symphony.com')
+
+process.env['HUBOT_SYMPHONY_HOST'] = 'foundation-bot.symphony.com'
+process.env['HUBOT_SYMPHONY_PUBLIC_KEY'] = './test/resources/publicKey.pem'
+process.env['HUBOT_SYMPHONY_PRIVATE_KEY'] = './test/resources/privateKey.pem'
+process.env['HUBOT_SYMPHONY_PASSPHRASE'] = 'changeit'
 
 describe 'Adapter test suite', () ->
   constructorProps = ['HUBOT_SYMPHONY_HOST', 'HUBOT_SYMPHONY_PUBLIC_KEY', 'HUBOT_SYMPHONY_PRIVATE_KEY', 'HUBOT_SYMPHONY_PASSPHRASE']
 
   for constructorProp in constructorProps
     it "should throw on construction if #{constructorProp} missing", () ->
-      process.env[propToSet] = 'foo' for propToSet in constructorProps.filter (p) -> p isnt constructorProp
-      assert.throws(SymphonyAdapter.use, new RegExp("#{constructorProp} undefined"))
+      prop = process.env[constructorProp]
+      delete process.env[constructorProp]
+      assert.throws(SymphonyAdapter.use, new RegExp("#{constructorProp} undefined"))
+      process.env[constructorProp] = prop
+
+  it 'should connect and receive message', (done) ->
+    robot = _fakeRobot()
+    adapter = SymphonyAdapter.use(robot)
+    adapter.on 'connected', () ->
+      assert.isDefined(adapter.symphony)
+      robot.on 'received', () ->
+        assert.isAtLeast((m for m in robot.received when m.message.message is '<messageML>Hello World</messageML>').length, 1)
+        adapter.close()
+        done()
+    adapter.run()
+
+  _fakeRobot = ->
+    robot = new EventEmitter
+    # noop the logging
+    robot.logger =
+      logs: {}
+      log: (type, message) ->
+        @logs[type] ?= []
+        @logs[type].push(message)
+      info: (message) ->
+        @log('info', message)
+      debug: (message) ->
+        @log('debug', message)
+      error: (message) ->
+        @log('error', message)
+    # record all received messages
+    robot.received = []
+    robot.receive = (msg) ->
+      @received.push msg
+      robot.emit 'received'
+    robot