Skip to content

Commit

Permalink
Merge pull request #26714 from oscarbenjamin/pr_lambdify_113
Browse files Browse the repository at this point in the history
Fix gh-26690 (1.13 branch)
  • Loading branch information
oscarbenjamin committed Jun 16, 2024
2 parents 75630d4 + fe39baf commit 015e6a5
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:
- '1.13'
env:
release_branch: '1.13'
release_version: '1.13.0rc1'
release_version: '1.13.0rc2'
final_release_version: '1.13.0'
previous_version: '1.12.1'
dev_version: '1.14-dev'
Expand Down
2 changes: 1 addition & 1 deletion sympy/release.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "1.13.0rc1"
__version__ = "1.13.0rc2"
2 changes: 1 addition & 1 deletion sympy/utilities/lambdify.py
Original file line number Diff line number Diff line change
Expand Up @@ -1210,7 +1210,7 @@ def _preprocess(self, args, expr):
elif isinstance(arg, DeferredVector):
s = str(arg)
elif isinstance(arg, Basic) and arg.is_symbol:
s = self._argrepr(arg)
s = str(arg)
if dummify or not self._is_safe_ident(s):
dummy = Dummy()
if isinstance(expr, Expr):
Expand Down
12 changes: 12 additions & 0 deletions sympy/utilities/tests/test_lambdify.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
from sympy.tensor.indexed import IndexedBase
from sympy.utilities.lambdify import lambdify
from sympy.utilities.iterables import numbered_symbols
from sympy.vector import CoordSys3D
from sympy.core.expr import UnevaluatedExpr
from sympy.codegen.cfunctions import expm1, log1p, exp2, log2, log10, hypot
from sympy.codegen.numpy_nodes import logaddexp, logaddexp2
Expand Down Expand Up @@ -927,6 +928,17 @@ def test_dummification():
raises(SyntaxError, lambda: lambdify(2 * F(t), 4 * F(t) + 5))


def test_lambdify__arguments_with_invalid_python_identifiers():
# see sympy/sympy#26690
N = CoordSys3D('N')
xn, yn, zn = N.base_scalars()
expr = xn + yn
f = lambdify([xn, yn], expr)
res = f(0.2, 0.3)
ref = 0.2 + 0.3
assert abs(res-ref) < 1e-15


def test_curly_matrix_symbol():
# Issue #15009
curlyv = sympy.MatrixSymbol("{v}", 2, 1)
Expand Down

0 comments on commit 015e6a5

Please sign in to comment.