Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate methods wrongly associated to Quantity instead of UnitSystem #17765

Open
Upabjojr opened this issue Oct 20, 2019 · 2 comments
Open

Deprecate methods wrongly associated to Quantity instead of UnitSystem #17765

Upabjojr opened this issue Oct 20, 2019 · 2 comments
Labels
physics.units Units and dimensions

Comments

@Upabjojr
Copy link
Contributor

Upabjojr commented Oct 20, 2019 •
edited

Some methods in the units module are implemented in the Quantity class while they should be implemented in the UnitSystem class.

Some methods have been already deprecated, see:
#17765
@oscarbenjamin
Copy link
Contributor

@Upabjojr can you clarify what this means? We have many open, old issues like this that are impossible to understand to anyone except the author. Will you even understand what this means when looking at it in the future?

@oscarbenjamin oscarbenjamin added the physics.units Units and dimensions label Oct 21, 2019
@Upabjojr
Copy link
Contributor Author

This issue will be linked to deprecation warnings.

@Upabjojr Upabjojr mentioned this issue Oct 22, 2019
Merged
@Upabjojr Upabjojr changed the title Transfer methods from Quantity to UnitSystem Deprecate methods wrongly associated to Quantity instead of UnitSystem Oct 22, 2019
@asherp asherp mentioned this issue Feb 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
physics.units Units and dimensions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oscarbenjamin @Upabjojr