Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sympy 1.6.1 ? #19557

Closed
FabioLuporini opened this issue Jun 15, 2020 · 9 comments
Closed

sympy 1.6.1 ? #19557

FabioLuporini opened this issue Jun 15, 2020 · 9 comments
Milestone

Comments

@FabioLuporini
Copy link
Contributor

Hi, is there any plan on releasing 1.6.1, just like we had 1.5.1 shortly after 1.5? We're unfortunately stuck with 1.5.1, but the patches we've submitted have already been merged into SymPy master, and we're looking forward to jump to 1.6. Thanks!

@oscarbenjamin
Copy link
Contributor

Which patches are you referring to?

@FabioLuporini
Copy link
Contributor Author

FabioLuporini commented Jun 15, 2020

Strictly speaking, the only one we actually need is #19431 . #19533 is the other one (though this one is more of a "I'd really like to have it, but I can survive without for the time being)

the bug fixed in #19431 really kills our code

@FabioLuporini
Copy link
Contributor Author

Note: edited my previous reply (wrong PR numbers before, now it should be fine)

@oscarbenjamin oscarbenjamin added this to the SymPy 1.6.1 milestone Jun 15, 2020
@oscarbenjamin
Copy link
Contributor

The normal plan is we would only make a bugfix release (i.e. 1.6.1) if regressions were identified in 1.6 (relative to 1.5.1). Also 1.6.1 would be based off the 1.6 branch rather than master so any fixes need to be cherry-picked to that branch. It's important to say when opening an issue that represents a regression that it is a regression so that any fix could be included in a bugfix release.

Until now the only regression I knew of was #19532.

@sylee957 sylee957 added Releasing Issues relating to the automated release scripts. Use milestones to block issues on a release. and removed Releasing Issues relating to the automated release scripts. Use milestones to block issues on a release. labels Jun 15, 2020
@FabioLuporini
Copy link
Contributor Author

#19431 was a regression AFAICT? apologies if it wasn't made clear in the PR description. Looping in @mloubout (who wrote the actual patch)

@mloubout
Copy link
Contributor

mloubout commented Jun 15, 2020

Yes this was a regression, I apologize if I haven't tagged it correctly, I tried to follow the guidelines but was the first time I PRed into sympy so I may have missed some parts.
As @FabioLuporini this is somethign that forces us to be fixed at 1.5.1 as this is an issue that make 1.6 unusable for us due to the presence of the Dummy object after collection.

@oscarbenjamin
Copy link
Contributor

No need to apologise. It's just best to explicitly say if something is a regression and since what version.

We can do a 1.6.1 release but I think we need a fix for #19532 first.

@oscarbenjamin
Copy link
Contributor

I've start preparing for the release (#19598). The issue tracking the release is #19599

@oscarbenjamin
Copy link
Contributor

#19601 applies #19431 to the 1.6 branch for release in 1.6.1 and will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants