New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unevaluated collect with symbols in factors #19431
Conversation
✅ Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Looks good. Ready to merge when tests pass. |
Codecov Report
@@ Coverage Diff @@
## master #19431 +/- ##
=============================================
+ Coverage 75.651% 75.653% +0.001%
=============================================
Files 652 652
Lines 169712 169712
Branches 40051 40051
=============================================
+ Hits 128390 128393 +3
+ Misses 35720 35714 -6
- Partials 5602 5605 +3 |
Thanks, this is in. |
References to other Issues or PRs
Fixes #19433
Brief description of what is fixed or changed
This PR fixes a small issue in
collect
with the collected symbol in the factor. Current version does:that contains an undefined
Dummy
in the collected expression,. This fixes the behavior applying replacement to the factors and outputs in this example.Other comments
Release Notes