Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to follow the documentation style guide #19591

Open
asmeurer opened this issue Jun 18, 2020 · 13 comments
Open

Update documentation to follow the documentation style guide #19591

asmeurer opened this issue Jun 18, 2020 · 13 comments

Comments

@asmeurer
Copy link
Member

This issue should serve as a master issue for tracking which parts of the documentation follow the style guide that was developed as part of GSoD 2019 https://docs.sympy.org/latest/documentation-style-guide.html.

So far, following modules have been updated

@Soumi7
Copy link
Contributor

Soumi7 commented Jun 19, 2020

Will start working on implementing the style guide to functions.elementary.

@Soumi7
Copy link
Contributor

Soumi7 commented Jun 19, 2020

@Sc0rpi0n101
I will implement the style guide for elementary submodule in functions, you suggested having the Parameters section before examples.

Should I then add the Parameters list before the examples when I add them here?

@Sc0rpi0n101
Copy link
Member

I think we should finish the discussion regarding the Docstring sections and update the Documentation style guide before starting with the implementation.

Updating the docstrings now and then updating the guide later would require them to be changed later again. That would just be unnecessary extra work.
It would be better to change the required section order, add the missing sections, etc. in the style guide and change the docstrings as per the updated style guide.

@Soumi7
Copy link
Contributor

Soumi7 commented Jun 19, 2020

@Sc0rpi0n101

Yes I think that too.

Then I will have to change the docstring sections in this documentation style guide first right?

https://github.com/sympy/sympy/blob/master/doc/src/documentation-style-guide.rst

@Soumi7
Copy link
Contributor

Soumi7 commented Jun 19, 2020

kk
This is my proposed flowchart of the docstring sections and their order. Suggestions are welcome!

@asmeurer
Copy link
Member Author

These things were already discussed when we wrote the guide last year so we should stick with what the guide says now. If we want to change the guide we should start a new discussion, but it shouldn't block any work to update things to the current guide. Also any such discussion should reference the discussions from last year that lead to the current way things are.

@asmeurer
Copy link
Member Author

Note that most of the discussions about this happened at #17715. I don't recall if we discuss this on that issue or in the private GSoD calls, but I do remember we explicitly chose to put examples up front.

@Soumi7
Copy link
Contributor

Soumi7 commented Jun 22, 2020

As discussed before, I will stick to the latest guide for updating the docstrings. In #19613, I have added the same order in the docstring in the latest documentation style guide developed in GSoD 2019, but the rendering has produced slightly different results.

@asmeurer
Copy link
Member Author

Regarding "returns", see also #17644

@Soumi7
Copy link
Contributor

Soumi7 commented Jul 13, 2020

#19753

@asmeurer
Copy link
Member Author

asmeurer commented Oct 6, 2020

Adding a documentation page to the Sphinx docs is fairly straightfoward. If you look in the doc/ directory you can just mimic what is already there. However, it can sometimes be difficult because existing documentation can have build errors or formatting issues, which would have to be fixed.

@Soumi7
Copy link
Contributor

Soumi7 commented Oct 7, 2020

Yes, will first make a list of all which are missing doc page by updating the comment, and then I will add the page to Sphinx docs.

This was referenced Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants