Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series: Possible improvements for Order of expressions involving factorials #22836

Open
anutosh491 opened this issue Jan 11, 2022 · 1 comment
Labels

Comments

@anutosh491
Copy link
Member

anutosh491 commented Jan 11, 2022

Being a contributor to the series module I have my fair share of idea of what sympy can achieve currently and what are it's limitations. Hence I make this issue thinking what a user would expect out of the following expressions shown below

Following basic pattern of growth of functions which is const < log(x) < x**n < 2**x or exp(x) < factorial(x) < x**x we have
On Master

>>> O(2**x + factorial(x), (x, oo))
O(exp(x*log(2)) + factorial(x), (x, oo))

>>> O(2**x + factorial(x) + x**x, (x, oo))
O(exp(x*log(x)) + factorial(x), (x, oo))

>>> O(x + factorial(x), (x, oo))
O(x*(1 + factorial(x)/x), (x, oo))

Expected Results: I also ended up checking the results on other CAS and If i remember the results worked properly on diofant

>>> O(2**x + factorial(x), (x, oo)) 
O(factorial(x), (x, oo))

>>> O(2**x + factorial(x) + x**x, (x, oo))
O((1/x)**(-x), (x, oo))

>>> O(x + factorial(x), (x, oo))
O( factorial(x) , (x, oo))

@anutosh491 anutosh491 changed the title Series: Possible improvements for output given by Order of certain expressions Series: Possible improvements for Order of expressions involving factorials Jan 12, 2022
skirpichev added a commit to skirpichev/diofant that referenced this issue Jan 12, 2022
skirpichev added a commit to skirpichev/diofant that referenced this issue Jan 12, 2022
@anutosh491
Copy link
Member Author

anutosh491 commented Jan 12, 2022

One of my Pr which for order which is under review #22247 (where the original issue has been addressed but we have been trying to extend our thinking to some mutlivariate cases) solves the first 2 of these but the 3rd one still remains the same !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant