New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tensor: fix printing of TensMul with imaginary coefficients #24474
tensor: fix printing of TensMul with imaginary coefficients #24474
Conversation
…ore trying to compare with 0. Fixes: sympy#24473
✅ Hi, I am the SymPy bot (v169). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
This seems to be more foolproof, and handle edge-cases better. Before this commit: >>> print(-I*K(p)) -1*I*K(p) After this commit: >>> print(-I*K(p)) -I*K(p) >>> print(I*K(p)) I*K(p) >>> print(K(p)) K(p) >>> print(-K(p)) -K(p)
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[41d90958] [6f0fd470]
<sympy-1.11.1^0>
- 1.30±0.1ms 844±10μs 0.65 solve.TimeSparseSystem.time_linear_eq_to_matrix(10)
- 3.62±0.1ms 1.51±0.03ms 0.42 solve.TimeSparseSystem.time_linear_eq_to_matrix(20)
- 6.89±0.4ms 2.25±0.03ms 0.33 solve.TimeSparseSystem.time_linear_eq_to_matrix(30)
Full benchmark results can be found as artifacts in GitHub Actions |
Could you add a test? |
Test is in a new file tensor/tests/test_printing.py
🟠Hi, I am the SymPy bot (v169). I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it. This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75. The following commits add new files:
If these files were added/deleted on purpose, you can ignore this message. |
@ThePauliPrinciple I've added a test in |
References to other Issues or PRs
Fixes #24473
Brief description of what is fixed or changed
To find the sign of the coefficient, earlier the code would just compare it to zero, leading to an error for an imaginary coefficient. Now, it uses
could_extract_minus_sign
.Other comments
After this PR:
Release Notes