Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on new or deleted files #75

Open
asmeurer opened this issue Feb 14, 2020 · 6 comments
Open

Warn on new or deleted files #75

asmeurer opened this issue Feb 14, 2020 · 6 comments

Comments

@asmeurer
Copy link
Member

If a commit introduces a new file or deletes a file, we could have the bot warn about it. That way people will notice issues like sympy/sympy#18488. We could also make it fail in such cases, unless someone with push access whitelists the files somehow, e.g., by mentioning the bot and listing the files. CC @oscarbenjamin

@asmeurer
Copy link
Member Author

asmeurer commented Feb 14, 2020

Here is a proof-of-concept. #77

For now it just posts a comment, like asmeurer/GitHub-Issues-Test#44 (comment), but we could easily make it post a failing status and require someone with push access to @mention the bot to whitelist the files.

@oscarbenjamin
Copy link
Contributor

I think this is definitely a good idea. It would be better to try this out for a while before having it fail the PR.

@oscarbenjamin
Copy link
Contributor

I've merged the PR. I guess we can leave this open for now until we're sure we're happy with it. Looks like this issue will get notified every time the bot posts though...

@asmeurer
Copy link
Member Author

Yeah, I noticed that. But I think it's useful because it can make it easy to find all the instances of this. It looks like there are already a few so far, but all are intended file additions.

@asmeurer
Copy link
Member Author

This needs to be fixed to skip merge commits. See sympy/sympy#18681

@asmeurer
Copy link
Member Author

#81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants