Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the plotting module does not follow PEP8 (code formating) #5914

Closed
Krastanov opened this issue Nov 1, 2011 · 7 comments
Closed

the plotting module does not follow PEP8 (code formating) #5914

Krastanov opened this issue Nov 1, 2011 · 7 comments
Labels
Bug Easy to Fix This is a good issue for new contributors. Feel free to work on this if no one else has already. imported

Comments

@Krastanov
Copy link
Member

The code there is a bit hard to read. It would be nice to have it refactored so it follows PEP8.

There are certain parts that are not pythonic but that's another problem needing more in-depth refactoring.

Original issue for #5914: http://code.google.com/p/sympy/issues/detail?id=2815
Original author: https://code.google.com/u/100157245271348669141/

@asmeurer
Copy link
Member

I didn't notice anything particularly bad (at least there are spaces around the equals signs).  Can you be more specific about what the problems are?

Original comment: http://code.google.com/p/sympy/issues/detail?id=2815#c1
Original author: https://code.google.com/u/asmeurer@gmail.com/

@Krastanov
Copy link
Member Author

Mainly 'if else' conditions that are all placed on the same line and are hard to read.

To find them one can use 

$ grep -E ': {1,}' *

It checks for ':' that are not the last character on the line for all files in the current directory.

**Labels:** CodeInDifficulty-Easy CodeInCategory-Code  

Original comment: http://code.google.com/p/sympy/issues/detail?id=2815#c2
Original author: https://code.google.com/u/100157245271348669141/

@asmeurer
Copy link
Member

I see.  This could also be considered as a subset of issue 4555 .

**Status:** Accepted  

Referenced issues: #4555
Original comment: http://code.google.com/p/sympy/issues/detail?id=2815#c3
Original author: https://code.google.com/u/asmeurer@gmail.com/

@asmeurer
Copy link
Member

asmeurer commented Nov 9, 2011

**Labels:** EasyToFix  

Original comment: http://code.google.com/p/sympy/issues/detail?id=2815#c4
Original author: https://code.google.com/u/asmeurer@gmail.com/

@Krastanov
Copy link
Member Author

**Labels:** CodeInImportedIntoSpreadsheet  

Original comment: http://code.google.com/p/sympy/issues/detail?id=2815#c5
Original author: https://code.google.com/u/100157245271348669141/

@asmeurer
Copy link
Member

**Labels:** -codeinimportedintospreadsheet CodeInImportedIntoMelange  

Original comment: http://code.google.com/p/sympy/issues/detail?id=2815#c6
Original author: https://code.google.com/u/asmeurer@gmail.com/

@vperic
Copy link
Contributor

vperic commented Nov 23, 2011

This was fixed in: https://github.com/sympy/sympy/pull/735

**Status:** Fixed  

Original comment: http://code.google.com/p/sympy/issues/detail?id=2815#c7
Original author: https://code.google.com/u/108713607268198052411/

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Easy to Fix This is a good issue for new contributors. Feel free to work on this if no one else has already. imported
Projects
None yet
Development

No branches or pull requests

4 participants