Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the behaviour of the deprecated Plot() #6086

Closed
Krastanov opened this issue Jan 13, 2012 · 12 comments
Closed

Change the behaviour of the deprecated Plot() #6086

Krastanov opened this issue Jan 13, 2012 · 12 comments
Labels
Bug Deprecation Removal Tracks the removal of a deprecated feature. See github.com/sympy/sympy/wiki/Deprecating-policy imported
Milestone

Comments

@Krastanov
Copy link
Member

Delete proxy_pyglet.py and correct all the docstrings.

Original issue for #6086: http://code.google.com/p/sympy/issues/detail?id=2987
Original author: https://code.google.com/u/100157245271348669141/
Referenced issues: #5944

@higagan-zz
Copy link

where is this file?

Original comment: http://code.google.com/p/sympy/issues/detail?id=2987#c1
Original author: https://code.google.com/u/100237993982653773286/

@Krastanov
Copy link
Member Author

Sorry, this one is unclear. This is to be fixed after sufficient time has passed for the deprecation to be effective. Currently the deprecation in question is not even in git. Check the blocked-on list.

After the new plotting module is in and after some time has passed this issue can be worked on.

Original comment: http://code.google.com/p/sympy/issues/detail?id=2987#c2
Original author: https://code.google.com/u/100157245271348669141/

@asmeurer
Copy link
Member

**Status:** Valid  

Original comment: http://code.google.com/p/sympy/issues/detail?id=2987#c3
Original author: https://code.google.com/u/asmeurer@gmail.com/

@Krastanov
Copy link
Member Author

**Labels:** CodeInCategory-Code  
**Blockedon:** -sympy:2845 sympy:2845  

Original comment: http://code.google.com/p/sympy/issues/detail?id=2987#c4
Original author: https://code.google.com/u/100157245271348669141/

@Krastanov
Copy link
Member Author

**Labels:** CodeInImportedIntoGoogleDocs  

Original comment: http://code.google.com/p/sympy/issues/detail?id=2987#c5
Original author: https://code.google.com/u/100157245271348669141/

@asmeurer
Copy link
Member

Postponing deprecation removals

**Labels:** -Milestone-Release0.7.3 Milestone-Release0.7.4  

Original comment: http://code.google.com/p/sympy/issues/detail?id=2987#c6
Original author: https://code.google.com/u/asmeurer@gmail.com/

@asmeurer
Copy link
Member

I guess this issue doesn't have a SymPyDeprecationWarning in the code, but it's still a deprecation removal.

Postponing the milestone.

**Labels:** -Milestone-Release0.7.4 Milestone-Release0.7.5 DeprecationRemoval  

Original comment: http://code.google.com/p/sympy/issues/detail?id=2987#c7
Original author: https://code.google.com/u/asmeurer@gmail.com/

@coder46
Copy link
Contributor

coder46 commented Dec 8, 2013

I would like to take up this issue. What should be used instead of Plot() ?

Original comment: http://code.google.com/p/sympy/issues/detail?id=2987#c8
Original author: https://code.google.com/u/117405907116416380654/

@asmeurer
Copy link
Member

asmeurer commented Dec 8, 2013

I'm not sure if this ones ready to be removed yet. Stefan?

**Cc:** krastano...@gmail.com  

Original comment: http://code.google.com/p/sympy/issues/detail?id=2987#c9
Original author: https://code.google.com/u/asmeurer@gmail.com/

@asmeurer
Copy link
Member

asmeurer commented Dec 8, 2013

Removing EasyToFix from the deprecation removal issues since it's confusing new contributors.

**Labels:** -EasyToFix  

Original comment: http://code.google.com/p/sympy/issues/detail?id=2987#c10
Original author: https://code.google.com/u/asmeurer@gmail.com/

@Krastanov
Copy link
Member Author

I think it is fine to remove it. It is here: https://github.com/sympy/sympy/blob/master/sympy/plotting/proxy_pyglet.py and the import here https://github.com/sympy/sympy/blob/master/sympy/plotting/__init__.py It was there just to keep old Pyglet-based plotting code in the wild working. It was deprecated more than a year ago in git and about a year ago in a release.

Nobody on the mailing list mentioned anything about pyglet since then, and no pyglet related question were posted on stackoverflow.

Fixing old code would be as simple as changing Plot to PygletPlot which is already imported by default.

Original comment: http://code.google.com/p/sympy/issues/detail?id=2987#c11
Original author: https://code.google.com/u/100157245271348669141/

@oscargus
Copy link
Contributor

Closing this as the file seems to be long gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Deprecation Removal Tracks the removal of a deprecated feature. See github.com/sympy/sympy/wiki/Deprecating-policy imported
Projects
None yet
Development

No branches or pull requests

6 participants