Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_args.py should also test rebuilability #6426

Open
asmeurer opened this issue Jul 18, 2012 · 4 comments
Open

test_args.py should also test rebuilability #6426

asmeurer opened this issue Jul 18, 2012 · 4 comments
Labels
Bug imported Testing Related to the test runner. Do not use for test failures unless it relates to the test runner itself

Comments

@asmeurer
Copy link
Member

asmeurer commented Jul 18, 2012 •
edited by oscarbenjamin

Not only is it important that all args be Basic, but non-Atom objects should be rebuildable from expr.func(*expr.args). We should test this in test_args.py. See issue 5169 .

Original issue for #6426: http://code.google.com/p/sympy/issues/detail?id=3327
Original author: https://code.google.com/u/asmeurer@gmail.com/
Referenced issues: #5169
@asmeurer
Copy link
Member Author

asmeurer commented Mar 5, 2014 

We have moved issues to GitHub https://github.com/sympy/sympy/issues .

**Labels:** Restrict-AddIssueComment-Commit

Original comment: http://code.google.com/p/sympy/issues/detail?id=3327#c1
Original author: https://code.google.com/u/asmeurer@gmail.com/

@asmeurer
Copy link
Member Author

asmeurer commented Mar 5, 2014 

We have moved issues to GitHub https://github.com/sympy/sympy/issues .

Original comment: http://code.google.com/p/sympy/issues/detail?id=3327#c2
Original author: https://code.google.com/u/asmeurer@gmail.com/

@michaelbukachi
Copy link

Hello, is this still an issue?

@asmeurer
Copy link
Member Author

I have started this at #10128, but feel free to take my branch and finish the work. I don't plan on doing it myself any time soon.

skirpichev added a commit to skirpichev/diofant that referenced this issue Feb 11, 2017
@skirpichev
Add regression test
56207e7 
This fixes sympy/sympy#6249.  posify(p) test still fails,
but I believe it doesn't have too much sense for matrices.

Also close sympy/sympy#6426 (fixed in diofant#339)
@oscarbenjamin oscarbenjamin added the Testing Related to the test runner. Do not use for test failures unless it relates to the test runner itself label Apr 20, 2019
@smichr smichr removed the Valid label Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug imported Testing Related to the test runner. Do not use for test failures unless it relates to the test runner itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@asmeurer @smichr @oscarbenjamin @jcrist @michaelbukachi