-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Deprecate solve_linear_system for linsolve #10000
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: AMiT Kumar <dtu.amit@gmail.com>
@@ -2046,7 +2047,7 @@ def update(determined, solution): | |||
bestsol = thissol | |||
return bestsol | |||
|
|||
|
|||
@deprecated(useinstead="linsolve", issue=10001, deprecated_since_version="0.7.6") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 0.7.7 (actually 1.0, but we'll have to change all instances of the former to the latter at some point anyway).
Nice, issue 10000! |
The tests need to be fixed. |
It's good to see this by the way. I think this fixes #4949. |
There are few more functions which duplicates solving linear equations, will try to finish this soon. Here are all the permutations:
|
else: | ||
return [] # no solutions | ||
from sympy.solvers.solveset import linsolve | ||
return linsolve(system, symbols) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the call signature different for linsolve (this function uses *symbols
)? If so, you might mention that in the deprecation notice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The **flags
have been removed.
Signed-off-by: AMiT Kumar <dtu.amit@gmail.com>
It seems there are some critical issues with |
TODO
@asmeurer @hargup