Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Deprecate solve_linear_system for linsolve #10000

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

aktech
Copy link
Member

@aktech aktech commented Oct 16, 2015

TODO

@asmeurer @hargup

Signed-off-by: AMiT Kumar <dtu.amit@gmail.com>
@@ -2046,7 +2047,7 @@ def update(determined, solution):
bestsol = thissol
return bestsol


@deprecated(useinstead="linsolve", issue=10001, deprecated_since_version="0.7.6")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 0.7.7 (actually 1.0, but we'll have to change all instances of the former to the latter at some point anyway).

@asmeurer
Copy link
Member

Nice, issue 10000!

@asmeurer
Copy link
Member

The tests need to be fixed.

@aktech aktech added solvers solvers.solveset Deprecation Removal Tracks the removal of a deprecated feature. See github.com/sympy/sympy/wiki/Deprecating-policy labels Oct 17, 2015
@asmeurer asmeurer added this to the 1.0 milestone Oct 27, 2015
@asmeurer
Copy link
Member

It's good to see this by the way. I think this fixes #4949.

@aktech
Copy link
Member Author

aktech commented Oct 27, 2015

I think this fixes #4949.

There are few more functions which duplicates solving linear equations, will try to finish this soon.

Here are all the permutations:

solve(equations, unknowns)
solve_linear_system(aug_matrix)
solve_linear_system_LU(aug_matrix, unknowns)
solve_poly_system(equations, unknowns)
solve_linear(single_equation)
polys.solvers.solve_lin_sys(equations, ring)
minsolve_linear_system(system, symbols)

else:
return [] # no solutions
from sympy.solvers.solveset import linsolve
return linsolve(system, symbols)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the call signature different for linsolve (this function uses *symbols)? If so, you might mention that in the deprecation notice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The **flags have been removed.

@aktech
Copy link
Member Author

aktech commented Nov 7, 2015

It seems there are some critical issues with rref which effects linsolve. If we have to release 1.0 soon, then we should skip deprecating this for now. We should just document that solve_linear_system will be replaced by linsolve and people should use linsolve. Similiar to what we would do with solveset (linsolve is a part of solveset module).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecation Removal Tracks the removal of a deprecated feature. See github.com/sympy/sympy/wiki/Deprecating-policy Merge conflict solvers.solveset solvers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants