subresultants_pg_amv.py contains functions for computing #10374

akritas · 2016-01-08T09:32:58Z

(a) euclidean/sturmian sequences in Q[x] and Z[x],
(b) subresultant polynomial sequences

It does NOT use the function prem which "messes up" the signs
in the euclidean/sturmian sequences. Instead it uses rem and remZ.

(a) euclidean/sturmian sequences in Q[x] and Z[x], (b) subresultant polynomial sequences It does NOT use the function prem which "messes up" the signs in the euclidean/sturmian sequences. Instead it uses rem and remZ.

(a) euclidean/sturmian sequences in Q[x] and Z[x], (b) subresultant polynomial remainder sequences It does NOT use the function prem which "messes up" the signs in the euclidean/sturmian sequences. Instead it uses rem and remZ.

added new function final_touches for the Van Vleck method

as well as several other changes final_touches and other minor changes to various functions

asmeurer · 2016-01-11T15:41:54Z

The Travis tests are failing because of code quality. You can run ./bin/test quality to see the errors. There are also failures because of PyPy, but those are due to bugs in PyPy, so you can ignore those.

asmeurer · 2016-01-11T15:42:25Z

@mattpap

the statement <from sympy import *> and removed some end of lines at the end of the file.

akritas · 2016-01-11T20:07:13Z

The Travis tests were complaining about the stmt from sympy import *,
and so I commented it out in the file. However, now when I import
separately the module and sympy I cannot run any examples. It tells
me "global name 'degree' is not defined"

Quoting Aaron Meurer notifications@github.com:

The Travis tests are failing because of code quality. You can run
./bin/test quality to see the errors. There are also failures
because of PyPy, but those are due to bugs in PyPy, so you can
ignore those.

Reply to this email directly or view it on GitHub:
#10374 (comment)

akritas · 2016-01-12T07:23:12Z

everything worked out fine the 4th time.
the only thing I cannot make is define the assert polys.

Quoting Aaron Meurer notifications@github.com:

The Travis tests are failing because of code quality. You can run
./bin/test quality to see the errors. There are also failures
because of PyPy, but those are due to bugs in PyPy, so you can
ignore those.

Reply to this email directly or view it on GitHub:
#10374 (comment)

correctly print 2x2 sylvester2 matrices

to correctly print the final matrix s2

uniformity of code and better readability

asmeurer · 2016-01-12T21:32:15Z

It wants you to import things manually like from sympy import (degree, Poly, ...)

of the file; also chnaged the oder of a statement in subresultants_vv

akritas · 2016-01-14T06:06:37Z

I did it; now that I have the whole package working
I will make updates to the docstrings and other minor
tune ups.

will let you know when I am done.

Quoting Aaron Meurer notifications@github.com:

It wants you to import things manually like from sympy import (degree, Poly, ...)

Reply to this email directly or view it on GitHub:
#10374 (comment)

with LC(p) < 0, and slightly modified the docstring 2. slightly altered code + docstring of modified_subresultants_amv(p,q,x) 3. slightly altered the docstring of sturm_pg(p, q, x, method=0) 4. same for sturm_amv(p, q, x, method=0) 5. slightly altered code + docstring of subresultants_pg(p,q,x)

akritas · 2016-01-14T17:02:20Z

After today's changes I think I am done! Let me know if there is
anything else to be done.

Quoting Aaron Meurer notifications@github.com:

It wants you to import things manually like from sympy import (degree, Poly, ...)

Reply to this email directly or view it on GitHub:
#10374 (comment)

asmeurer · 2016-01-15T15:08:09Z

@jksuom do you have any thoughts on this?

jksuom · 2016-01-15T15:16:45Z

I believe the algorithms are useful. Some modifications would be needed: The file should probably be moved to polys. Its name should be changed, preferably to indicate that the algorithms are for polynomials with integer and rational coefficients. Test file should be created. I expect that to be the bulk of the remaining task.

akritas · 2016-01-15T20:03:39Z

Very good points both of them. Regarding the name of the
file, I agree that it is rather cryptic and hard to decipher.

Maybe subresultants_qq_zz is better. Any better suggestions?

I will also add some comments for the module as a whole.

As for the test file, it would help me a lot if I could see one.

Quoting Kalevi Suominen notifications@github.com:

I believe the algorithms are useful. Some modifications would be
needed: The file should probably be moved to polys. Its name should
be changed, preferably to indicate that the algorithms are for
polynomials with integer and rational coefficients. Test file should
be created. I expect that to be the bulk of the remaining task.

Reply to this email directly or view it on GitHub:
#10374 (comment)

asmeurer · 2016-01-15T20:07:09Z

Take a look at the files in the various tests directories. The basic idea is that you write a file test_subresultants_qq_zz.py in the tests directory next to your module with functions like

def test_some_func():
    assert some_func(input) == output
    assert some_func(input2) == output2

where "some_func" is the function you are testing. You can then run the tests with

./bin/test subresultants

…it to polys. Also have created the test file test_subresultants_qq_zz.py and moved it to polys/tests

akritas · 2016-01-17T10:45:45Z

Thank you. Very helpful. I did it and passed the travis test.
Let me know if it OK.

Quoting Aaron Meurer notifications@github.com:

Take a look at the files in the various tests directories. The
basic idea is that you write a file test_subresultants_qq_zz.py in
the tests directory next to your module with functions like
def test_some_func():
    assert some_func(input) == output
    assert some_func(input2) == output2
where "some_func" is the function you are testing. You can then run
the tests with
./bin/test subresultants
Reply to this email directly or view it on GitHub:
#10374 (comment)

jksuom · 2016-01-17T13:13:45Z

Thank you. That was quick. This looks good to me.

jksuom · 2016-01-19T08:04:41Z

I think this is ready. Thank you for your work.

subresultants_pg_amv.py contains functions for computing

akritas · 2016-01-19T08:32:42Z

It was a great pleasure and I learned a lot!

Quoting Kalevi Suominen notifications@github.com:

I think this is ready. Thank you for your work.

Reply to this email directly or view it on GitHub:
#10374 (comment)

asmeurer · 2016-01-19T15:50:34Z

@akritas can you add something to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.0 about this

akritas · 2016-01-19T20:30:05Z

done

akritas added 4 commits January 8, 2016 10:38

subresultants_pg_amv.py contains functions for computing

ae129fd

(a) euclidean/sturmian sequences in Q[x] and Z[x], (b) subresultant polynomial sequences It does NOT use the function prem which "messes up" the signs in the euclidean/sturmian sequences. Instead it uses rem and remZ.

subresultants_pg_amv.py contains functions for computing

1ab1597

(a) euclidean/sturmian sequences in Q[x] and Z[x], (b) subresultant polynomial remainder sequences It does NOT use the function prem which "messes up" the signs in the euclidean/sturmian sequences. Instead it uses rem and remZ.

Cleaned up the file; deleted trailing white space;

7c27de8

added new function final_touches for the Van Vleck method

Made several changes in the sylveste function (deg(0) != -oo anymore)

e57ad24

as well as several other changes final_touches and other minor changes to various functions

./bin/test quality passed [OK], AFTER I commented out

16cd7da

the statement <from sympy import *> and removed some end of lines at the end of the file.

akritas added 3 commits January 12, 2016 12:58

Improved the function subresultants_vv(p, q, x, 1) to

0d90be0

correctly print 2x2 sylvester2 matrices

One more code dorrection in subresultants_vv(p, q, x, 1)

aa6f0ed

to correctly print the final matrix s2

One final(?) code improvement to subresultants_vv(p, q, x, 1) for

67695ec

uniformity of code and better readability

entered the list of functions imported frm sympy at the top

b5b6eab

of the file; also chnaged the oder of a statement in subresultants_vv

akritas added 3 commits January 17, 2016 08:03

Have changed the name of the module to subresultants_qq_zz and moved …

24e47ce

…it to polys. Also have created the test file test_subresultants_qq_zz.py and moved it to polys/tests

removed trailing spaces from test file

de3fce0

white spaces were in the module, not in the test file

6277b3c

jksuom pushed a commit that referenced this pull request Jan 19, 2016

Merge pull request #10374 from akritas/subresultants

1ab5e8c

subresultants_pg_amv.py contains functions for computing

jksuom merged commit 1ab5e8c into sympy:master Jan 19, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

subresultants_pg_amv.py contains functions for computing #10374

subresultants_pg_amv.py contains functions for computing #10374

akritas commented Jan 8, 2016

asmeurer commented Jan 11, 2016

asmeurer commented Jan 11, 2016

akritas commented Jan 11, 2016

akritas commented Jan 12, 2016

asmeurer commented Jan 12, 2016

akritas commented Jan 14, 2016

akritas commented Jan 14, 2016

asmeurer commented Jan 15, 2016

jksuom commented Jan 15, 2016

akritas commented Jan 15, 2016

asmeurer commented Jan 15, 2016

akritas commented Jan 17, 2016

jksuom commented Jan 17, 2016

jksuom commented Jan 19, 2016

akritas commented Jan 19, 2016

asmeurer commented Jan 19, 2016

akritas commented Jan 19, 2016

subresultants_pg_amv.py contains functions for computing #10374

subresultants_pg_amv.py contains functions for computing #10374

Conversation

akritas commented Jan 8, 2016

asmeurer commented Jan 11, 2016

asmeurer commented Jan 11, 2016

akritas commented Jan 11, 2016

akritas commented Jan 12, 2016

asmeurer commented Jan 12, 2016

akritas commented Jan 14, 2016

akritas commented Jan 14, 2016

asmeurer commented Jan 15, 2016

jksuom commented Jan 15, 2016

akritas commented Jan 15, 2016

asmeurer commented Jan 15, 2016

akritas commented Jan 17, 2016

jksuom commented Jan 17, 2016

jksuom commented Jan 19, 2016

akritas commented Jan 19, 2016

asmeurer commented Jan 19, 2016

akritas commented Jan 19, 2016