Update printer.py #11912
Merged
Update printer.py #11912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced Therefor with Therefore in line 19 (issue #11911)
|
Thanks. Merging. |
|
From next time. You can use "Fixes #issue_number" in your commit message, that will automatically close the corresponding issue. I am now closing it manually. |
|
Thank you for your feedback . Actually I am new to open source contribution so kindly guide me.
…----- Original Message -----
From: "Gaurav Dhingra" <notifications@github.com>
To: "sympy/sympy" <sympy@noreply.github.com>
Cc: "Mohit Chandra" <mohit.chandra@research.iiit.ac.in>, "Author" <author@noreply.github.com>
Sent: Tuesday, December 6, 2016 1:03:47 PM
Subject: Re: [sympy/sympy] Update printer.py (#11912)
From next time. You can use "Fixes #issue_number" in your commit message, that will automatically close the corresponding issue. I am now doing it manually.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#11912 (comment)
|
|
@mohit3011 if you can suggest how to make the message "<If this pull request fixes an issue please indicate which issue by typing "Fixes #NNNN" below.>" clearer please let us know (not trying to be passive aggressive, really do want to make it clearer, since it obviously didn't work in this instance). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced Therefor with Therefore in line 19 (issue #11911)