Added a bunch of constants to sympy/physics/units #12450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bjodah Can you please take a look? I'd like to have this merged as I'm still short on the patch requirement. |
|
Should this wait for #12246 ? |
|
OK, the unification of units is complete. You can make your mod on top of the new master and repush here with the |
|
Updated @smichr. Can you please take a look here? |
ShikharJ
changed the title
|
double checked it; looks good. I see that you (rightly) didn't use the abbreviation for Faraday's constant (F) which is already used for the Farad. |
|
@smichr Thank you very much for the quick review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and suggest improvements.
For CODATA values refer: http://physics.nist.gov/cuu/Constants/Table/allascii.txt