Unpythonicity in baseclass.py #12480
Conversation
| current = components[i] | ||
| following = components[i + 1] | ||
|
|
||
| for current, following in zip(components, components[1:]): |
There was a problem hiding this comment.
zip automatically stops on the shortest iterator, so it isn't necessary.
There was a problem hiding this comment.
Pythonic as well as a little more fast. I am okay with it.
| @@ -193,7 +193,7 @@ def guess_generating_function_rational(v, X=Symbol('x')): | |||
| if n <= 1: return None | |||
| # b) compute the numerator as p | |||
| p = [sum(v[i-k]*q[k] for k in range(min(i+1, n))) | |||
| for i in range(len(v))] # TODO: maybe better with: len(v)>>1 | |||
| for i in range(len(v)>>1)] | |||
There was a problem hiding this comment.
What does this change do? Also len(v)//2 is more readable than len(v) >> 1.
There was a problem hiding this comment.
Let's look at find_simple_recurrence_vector(l). Firstly, here is used >> 1 instead of // 2, and I use the same for uniformity. Secondly, len(find_simple_recurrence_vector(l)) <= (len(l) >> 1). In guess_generating_function_rational we can see that sum(v[i-k] * q[k] for k in range(m)) == 0, where m = n = len(q) <= (len(v) >> 1) , and it is unnecessary to calculate it for i >= (len(v) >> 1), because the sum is 0.
There was a problem hiding this comment.
Verified this is true for i >= (len(v) >> 1). So I have verified with the current tests.
|
Looks good. Merging this. Thanks @abramovat . |
No description provided.