Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use det from matrices module instead of inner code in vector module. #13069

Merged
merged 1 commit into from Jul 31, 2017
Merged

Use det from matrices module instead of inner code in vector module. #13069

merged 1 commit into from Jul 31, 2017

Conversation

szymag
Copy link
Contributor

@szymag szymag commented Jul 31, 2017

This PR removes some code from vector class in vector module.
Instead of computing det by own code in cross method I use code from matrices.

Docstring suggest that we can't use code from matrices but I see no reason why we can't do that.

@szymag
Copy link
Contributor Author

szymag commented Jul 31, 2017

ping @Upabjojr

@smichr
Copy link
Member

smichr commented Jul 31, 2017

+1

@Upabjojr Upabjojr merged commit f28b8dd into sympy:master Jul 31, 2017
@szymag szymag deleted the cross_product branch August 23, 2017 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@szymag @smichr @Upabjojr