New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use det from matrices module instead of inner code in vector module. #13069

Merged
merged 1 commit into from Jul 31, 2017

Conversation

Projects
None yet
3 participants
@szymag
Contributor

szymag commented Jul 31, 2017

This PR removes some code from vector class in vector module.
Instead of computing det by own code in cross method I use code from matrices.

Docstring suggest that we can't use code from matrices but I see no reason why we can't do that.

@szymag

This comment has been minimized.

Show comment
Hide comment
@szymag

szymag Jul 31, 2017

Contributor

ping @Upabjojr

Contributor

szymag commented Jul 31, 2017

ping @Upabjojr

@smichr

This comment has been minimized.

Show comment
Hide comment
@smichr

smichr Jul 31, 2017

Member

+1

Member

smichr commented Jul 31, 2017

+1

@Upabjojr Upabjojr merged commit f28b8dd into sympy:master Jul 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@szymag szymag deleted the szymag:cross_product branch Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment