Densityop general : very basic features for density operators #1312

gdevanla · 2012-05-25T17:11:26Z

This version implements the initial features needed for Density operator. Using qubits as states is not fully supported in this version.

…sts.

…easure that works

…py measure.

* Now inherits from HermitianOperator. * Simpler design. * Updated printing.

…value error need to be handled in tests

Krastanov · 2012-05-25T19:55:52Z

SymPy Bot Summary: 🔴 There were test failures.

@gdevanla: Please fix the test failures.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYqcYaDA

Interpreter: /usr/bin/python2.6 (2.6.7-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 92d8dad
branch hash: 398108be73cac096d17d7cf48c285737fb156c67

Automatic review by SymPy Bot.

Krastanov · 2012-05-25T20:13:18Z

SymPy Bot Summary: 🔴 There were test failures.

@gdevanla: Please fix the test failures.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY8K4aDA

Interpreter: /usr/bin/python3 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes
Test command: ./bin/test && ./bin/doctest
master hash: 92d8dad
branch hash: 398108be73cac096d17d7cf48c285737fb156c67

Automatic review by SymPy Bot.

Krastanov · 2012-05-27T12:46:53Z

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYtZQbDA

Interpreter: /home/stefan/python2.5/Python-2.5.6/python (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: fcc69a6
branch hash: 92ca868

Automatic review by SymPy Bot.

Krastanov · 2012-05-27T13:07:02Z

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYxL4aDA

Interpreter: /usr/bin/python3 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes
Test command: ./bin/test && ./bin/doctest
master hash: c4d3b5b
branch hash: 92ca868

Automatic review by SymPy Bot.

flacjacket · 2012-05-29T15:54:59Z

sympy/physics/quantum/density.py

+        """Expands the density operator into the matrix format"""
+        terms = []
+        for (state, prob) in self.args:
+            terms.append(prob*state*Dagger(state))


You might want to create OuterProducts here. Just enclosing (state * Dagger(state)) in parentheses will automatically take care of that.

Yes, I would use the parens to get OuterProducts here.

gdevanla · 2012-05-30T16:30:15Z

@ellisonbg @flacjacket @certik I have updated the PR with changes suggested ( except for Notebook examples)

@ellisonbg I have not used used Notebook before. Do you think I can add the changes(examples for Notebook) you suggested as part of examples in the next PR. That will give me time to work on that. Or else, I can update this PR is next few days. I am fine either way.

@flacjacket I will update test_printing for density operators, once your printing related PR is merged. Will that be sufficient?

ellisonbg · 2012-05-30T16:56:28Z

Let's add the notebook now if you can. Let us know if you have any problems installing it. Here are link to the IPython docs for this:

http://ipython.org/ipython-doc/dev/install/index.html
http://ipython.org/ipython-doc/dev/interactive/htmlnotebook.html

Krastanov · 2012-05-30T17:18:30Z

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY5t0aDA

Interpreter: /opt/pym32/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (32-bit)
Cache: yes
Test command: setup.py test
master hash: 1f3fd71
branch hash: 6d66a1b

Automatic review by SymPy Bot.

Krastanov · 2012-05-30T17:38:06Z

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYuZQbDA

Interpreter: /usr/bin/python2.7 (2.7.2-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 1f3fd71
branch hash: 6d66a1b

Automatic review by SymPy Bot.

flacjacket · 2012-05-30T17:45:19Z

Waiting on the printing tests is fine, I'd just brought it up so you were aware of it, but that was before I noticed that you'd mentioned it on your blog post.

certik · 2012-05-30T17:49:47Z

sympy/physics/quantum/density.py

+        """Return list of all states"""
+        return Tuple(*[arg[0] for arg in self.args])
+
+    def probs(self):


There should be a docstring with one or two doctests showing how to use probs().

Krastanov · 2012-05-30T18:01:17Z

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYj6caDA

Interpreter: /usr/bin/python3 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes
Test command: ./bin/test && ./bin/doctest
master hash: 1f3fd71
branch hash: 6d66a1b

Automatic review by SymPy Bot.

gdevanla · 2012-05-30T21:31:47Z

@ellisonbg I see that there is an examples/notebook folder where there is 1 .ipynb file. Should I add my notebook to that folder or to examples/advanced folder.

Also, I do not see any notebook for other quantum modules. Am I looking at the wrong place?

Either ways, once I have the location I can upload an updated version of the file. I will be starting off from the file you already had at:
https://github.com/ellisonbg/sympy/blob/densityop/examples/notebooks/density.ipynb.

gdevanla · 2012-05-30T22:47:10Z

Fixed the doc strings and also added density.ipynb to examples/notebook.

ellisonbg · 2012-05-30T22:55:50Z

Guru,

On Wed, May 30, 2012 at 2:31 PM, Guru Devanla
reply@reply.github.com
wrote:

@ellisonbg I see that there is an examples/notebook folder where there is 1 .ipynb file. Should I add my notebook to that folder or to examples/advanced folder.

I guess let's use examples/notebook

Also, I do not see any notebook for other quantum modules. Am I looking at the wrong place?

No, but @flacjacket wasn't there a notebook for spin examples?

Either ways, once I have the location I can upload an updated version of the file. I will be starting off from the file you already had at:
https://github.com/ellisonbg/sympy/blob/densityop/examples/notebooks/density.ipynb.

Reply to this email directly or view it on GitHub:
#1312 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

flacjacket · 2012-05-30T23:05:55Z

There wasn't ever one that I submitted. I've got some stuff I did for testing myself, I'll try to put them together and clean it up and get it in another PR.

ellisonbg · 2012-05-30T23:38:32Z

OK thanks.

On Wed, May 30, 2012 at 4:05 PM, Sean Vig
reply@reply.github.com
wrote:

There wasn't ever one that I submitted. I've got some stuff I did for testing myself, I'll try to put them together and clean it up and get it in another PR.

Reply to this email directly or view it on GitHub:
#1312 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

Krastanov · 2012-05-31T00:36:59Z

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY1Y8aDA

Interpreter: /opt/pym32/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (32-bit)
Cache: yes
Test command: setup.py test
master hash: 1f3fd71
branch hash: 1304488

Automatic review by SymPy Bot.

Krastanov · 2012-05-31T00:54:47Z

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYvJQbDA

Interpreter: /usr/bin/python2.7 (2.7.2-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 1f3fd71
branch hash: 1304488

Automatic review by SymPy Bot.

Krastanov · 2012-05-31T01:15:15Z

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYkacaDA

Interpreter: /usr/bin/python3 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes
Test command: ./bin/test && ./bin/doctest
master hash: 1f3fd71
branch hash: 1304488

Automatic review by SymPy Bot.

flacjacket · 2012-06-01T02:59:40Z

Hm, that last line of your notebook looks like a bug in qapply. It should split up OuterProducts, but it only does so when it appears on the left of a multiplication, so it misses it when it is the right most term in the expression (as in this case).

ellisonbg · 2012-06-01T04:24:03Z

Yes, I think this is a bug. @gdevania can you tackle this bug in a
separate pull request?

On Thu, May 31, 2012 at 7:59 PM, Sean Vig
reply@reply.github.com
wrote:

Hm, that last line of your notebook looks like a bug in qapply. It should split up OuterProducts, but it only does so when it appears on the left of a multiplication, so it misses it when it is the right most term in the expression (as in this case)

Reply to this email directly or view it on GitHub:
#1312 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

gdevanla · 2012-06-01T08:56:12Z

Sure, will track it and work on it on a separate PR.

flacjacket · 2012-06-05T04:06:24Z

This looks good for a first iteration, I'll merge this in.

Densityop general : very basic features for density operators

addisonc and others added 22 commits May 25, 2012 12:04

Made basic density op logic

2eae81d

Added multiplication functionality, and apply logic. Needs further te…

933c70c

…sts.

Minor changes to calling of density

fecd1b9

Added some tests for densityop

5ccf5c5

Got the constructor working closer to the way I want, added entropy m…

2ec5b6e

…easure that works

Added some tests rudimentary tests, Fixed what showed up. Added Entro…

2464e59

…py measure.

Changed densityOp to use new name qapply

cb7cf0d

Got reduced_density working, or so it seems

f01fba8

Added entang;lement measure and reduced density matrix thingy

37ab93f

Renaming the densityOp.py module to density.py.

6a9de03

Refactoring density operator to be more general.

43cb6bf

* Now inherits from HermitianOperator. * Simpler design. * Updated printing.

Adding qubit focused density matrix stuff.

a66ecdf

added test case to latex printing

02c9e80

Added _eval_args related validations. The test are incomplete. raise …

996f4c3

…value error need to be handled in tests

Complete all test cases for Density._eval_args()

92779db

doit() and represent() with OuterProduct

32313e5

doit() and represent() with OuterProduct

4df63ac

Update test cases to not use OuterProducts

3d43b75

removed untested files from this branch

0888abd

Fixed tests based on changes in operator for latex printing

699c3bd

Basic functionality for density opertors, complete tests and docstrings

eab787c

restored version from master

a1d1544

gdevanla added 3 commits May 27, 2012 06:58

Added tests for physics_quantum_density

6178cd1

Added tests for physics_quantum_density

4d7912c

added tests for physics_quantum_density

92ca868

flacjacket reviewed May 29, 2012
View reviewed changes

gdevanla added 2 commits May 30, 2012 10:54

Fixed Density.doit() to use Outer products, other minor changes

662a833

Changed operate_on to apply_op

6d66a1b

certik reviewed May 30, 2012
View reviewed changes

gdevanla added 2 commits May 30, 2012 17:36

Added doc strings, notebook examples for density

c7f4429

Added parameters in doc string for apply_op()

1304488

flacjacket added a commit that referenced this pull request Jun 5, 2012

Merge pull request #1312 from gdevanla/densityop_general

1174a6a

Densityop general : very basic features for density operators

flacjacket merged commit 1174a6a into sympy:master Jun 5, 2012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Densityop general : very basic features for density operators #1312

Densityop general : very basic features for density operators #1312

gdevanla commented May 25, 2012

Krastanov commented May 25, 2012

Krastanov commented May 25, 2012

Krastanov commented May 27, 2012

Krastanov commented May 27, 2012

flacjacket May 29, 2012

ellisonbg May 30, 2012

gdevanla commented May 30, 2012

ellisonbg commented May 30, 2012

Krastanov commented May 30, 2012

Krastanov commented May 30, 2012

flacjacket commented May 30, 2012

certik May 30, 2012

Krastanov commented May 30, 2012

gdevanla commented May 30, 2012

gdevanla commented May 30, 2012

ellisonbg commented May 30, 2012

flacjacket commented May 30, 2012

ellisonbg commented May 30, 2012

Krastanov commented May 31, 2012

Krastanov commented May 31, 2012

Krastanov commented May 31, 2012

flacjacket commented Jun 1, 2012

ellisonbg commented Jun 1, 2012

gdevanla commented Jun 1, 2012

flacjacket commented Jun 5, 2012

Densityop general : very basic features for density operators #1312

Densityop general : very basic features for density operators #1312

Conversation

gdevanla commented May 25, 2012

Krastanov commented May 25, 2012

Krastanov commented May 25, 2012

Krastanov commented May 27, 2012

Krastanov commented May 27, 2012

flacjacket May 29, 2012

Choose a reason for hiding this comment

ellisonbg May 30, 2012

Choose a reason for hiding this comment

gdevanla commented May 30, 2012

ellisonbg commented May 30, 2012

Krastanov commented May 30, 2012

Krastanov commented May 30, 2012

flacjacket commented May 30, 2012

certik May 30, 2012

Choose a reason for hiding this comment

Krastanov commented May 30, 2012

gdevanla commented May 30, 2012

gdevanla commented May 30, 2012

ellisonbg commented May 30, 2012

flacjacket commented May 30, 2012

ellisonbg commented May 30, 2012

Krastanov commented May 31, 2012

Krastanov commented May 31, 2012

Krastanov commented May 31, 2012

flacjacket commented Jun 1, 2012

ellisonbg commented Jun 1, 2012

gdevanla commented Jun 1, 2012

flacjacket commented Jun 5, 2012