Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminates unconditional conversion of numpy arrays of length 1 #13927

Closed
wants to merge 2 commits into from
Closed

Eliminates unconditional conversion of numpy arrays of length 1 #13927

wants to merge 2 commits into from

Conversation

Shikhar1998
Copy link
Contributor

References to other Issues or PRs

Fixes #13924

Brief description of what is fixed or changed

Moved the code that tries to convert to arrays above the code that tries to convert to int or float.

@Shikhar1998
Fixes issue sympy#13924
09d4984 
Changes made as suggested
@Shikhar1998
Code Restructured
c342774 
Handling for numpy arrays
@Shikhar1998
Copy link
Contributor Author

#13926, solves the same problem.

@jksuom jksuom mentioned this pull request Apr 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sympy.S doesn't preserve numpy arrays of length 1, and unconditionally converts its member to float
1 participant
@Shikhar1998