New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Work in Progress] Basic framework for restructured plot. #1468

Merged
merged 29 commits into from Aug 25, 2012

Conversation

Projects
None yet
5 participants
@catchmrbharath
Contributor

catchmrbharath commented Aug 7, 2012

This is a just a framework of functions that will replace plot which took care of all the possible plots.
The behaviour that is expected is provided in the docstrings. This pull request was made to get an opinion
on the names of the functions and the behaviour that has to be expected of these functions.

I will keep updating this branch with the code for the behaviour.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 7, 2012

This pull request fails (merged 85cd5a9 into 65b6582).

travisbot commented Aug 7, 2012

This pull request fails (merged 85cd5a9 into 65b6582).

@asmeurer

View changes

Show outdated Hide outdated sympy/plotting/plot_new.py
``expr`` : Expression representing the function of single variable
``range``: (x, 0 , 5), A 3 - tuple denoting the range of the free variable.
If the ranges is not specified, then a default range of (-10, 10) is used.

This comment has been minimized.

@asmeurer

asmeurer Aug 7, 2012

Member

Maybe add: "This may change in the future if a more advanced default range detection algorithm is detected."

@asmeurer

asmeurer Aug 7, 2012

Member

Maybe add: "This may change in the future if a more advanced default range detection algorithm is detected."

@asmeurer

View changes

Show outdated Hide outdated sympy/plotting/plot_new.py
=========
``expr_x`` : Expression representing the function along x.
``expr_y`` : Expression representing the function along y.
``range``: (u, 0 , 5), A 3 - tuple denoting the range of the parameter

This comment has been minimized.

@asmeurer

asmeurer Aug 7, 2012

Member

No space before ,, no space around -.

@asmeurer

asmeurer Aug 7, 2012

Member

No space before ,, no space around -.

@asmeurer

View changes

Show outdated Hide outdated sympy/plotting/plot_new.py
>>> plot_line(x**2, x, (x -5, 5))
No adaptive sampling.
>>> plot_line(x**2, adaptive = False, nb_of_points = 400)

This comment has been minimized.

@asmeurer

asmeurer Aug 7, 2012

Member

Don't put spaces around = when it's used to denote keyword arguments.

@asmeurer

asmeurer Aug 7, 2012

Member

Don't put spaces around = when it's used to denote keyword arguments.

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 7, 2012

Member

Why create a new file for this?

Member

asmeurer commented Aug 7, 2012

Why create a new file for this?

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov Aug 7, 2012

Member

SymPy Bot Summary: 🔴 There were test failures.

@catchmrbharath: Please fix the test failures.

Test command: setup.py test
master hash: 98cc80f
branch hash: 85cd5a99c5f32d08e756b0c827c3c5c46086ea65

Interpreter 1: 🔴 There were test failures.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYhcYiDA

Interpreter 2: 🔴 There were test failures.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYlPAhDA

Interpreter 3: 🔴 There were test failures.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYvbYiDA

Build HTML Docs: ✳️ All tests have passed.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYiJQjDA

Automatic review by SymPy Bot.

Member

Krastanov commented Aug 7, 2012

SymPy Bot Summary: 🔴 There were test failures.

@catchmrbharath: Please fix the test failures.

Test command: setup.py test
master hash: 98cc80f
branch hash: 85cd5a99c5f32d08e756b0c827c3c5c46086ea65

Interpreter 1: 🔴 There were test failures.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYhcYiDA

Interpreter 2: 🔴 There were test failures.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYlPAhDA

Interpreter 3: 🔴 There were test failures.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYvbYiDA

Build HTML Docs: ✳️ All tests have passed.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYiJQjDA

Automatic review by SymPy Bot.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 7, 2012

This pull request fails (merged d9efa1ea into 65b6582).

travisbot commented Aug 7, 2012

This pull request fails (merged d9efa1ea into 65b6582).

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov Aug 8, 2012

Member

SymPy Bot Summary: 🔴 There were test failures.

@catchmrbharath: Please fix the test failures.

Test command: setup.py test
master hash: 0d88b25
branch hash: d9efa1ea0a5efa812fe4e76e308cf3f6068b69c0

Interpreter 1: 🔴 There were test failures.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYn-0iDA

Interpreter 2: 🔴 There were test failures.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYkJQjDA

Interpreter 3: 🔴 There were test failures.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYqowjDA

Build HTML Docs: ✳️ All tests have passed.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYj5QjDA

Automatic review by SymPy Bot.

Member

Krastanov commented Aug 8, 2012

SymPy Bot Summary: 🔴 There were test failures.

@catchmrbharath: Please fix the test failures.

Test command: setup.py test
master hash: 0d88b25
branch hash: d9efa1ea0a5efa812fe4e76e308cf3f6068b69c0

Interpreter 1: 🔴 There were test failures.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYn-0iDA

Interpreter 2: 🔴 There were test failures.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYkJQjDA

Interpreter 3: 🔴 There were test failures.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYqowjDA

Build HTML Docs: ✳️ All tests have passed.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYj5QjDA

Automatic review by SymPy Bot.

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 8, 2012

Member

SymPy Bot Summary: 🔴 There were test failures (merged catchmrbharath/restructured_plot (d9efa1ea0a5efa812fe4e76e308cf3f6068b69c0) into master (0d88b25)).

@catchmrbharath: Please fix the test failures.

Interpreter 1: 🔴 There were test failures.
Interpreter: None (2.5.0-final-0)
Architecture: Darwin (32-bit)

Interpreter 2: 🔴 There were test failures.
Interpreter: None (2.6.6-final-0)
Architecture: Darwin (32-bit)

Interpreter 3: 🔴 There were test failures.
Interpreter: None (2.7.2-final-0)
Architecture: Darwin (32-bit)

Interpreter 4: 🔴 There were test failures.
Interpreter: /sw/bin//python2.6 (2.6.8-final-0)
Architecture: Darwin (64-bit)

Interpreter 5: 🔴 There were test failures.
Interpreter: /sw/bin//python2.7 (2.7.3-final-0)
Architecture: Darwin (64-bit)

Interpreter 6: 🔴 There were test failures.
Interpreter: None (3.2.2-final-0)
Architecture: Darwin (32-bit)

Interpreter 7: 🔴 There were test failures.
Interpreter: None (3.3.0-beta-1)
Architecture: Darwin (32-bit)

Interpreter 8: 🔴 There were test failures.
Interpreter: /sw/bin//python3.2 (3.2.3-final-0)
Architecture: Darwin (64-bit)

Interpreter 9: 🔴 There were test failures.
Interpreter: None (3.3.0-beta-1)
Architecture: Darwin (64-bit)

Build HTML Docs: 🔴 There were test failures.
Sphinx version: 1.1.3

Member

asmeurer commented Aug 8, 2012

SymPy Bot Summary: 🔴 There were test failures (merged catchmrbharath/restructured_plot (d9efa1ea0a5efa812fe4e76e308cf3f6068b69c0) into master (0d88b25)).

@catchmrbharath: Please fix the test failures.

Interpreter 1: 🔴 There were test failures.
Interpreter: None (2.5.0-final-0)
Architecture: Darwin (32-bit)

Interpreter 2: 🔴 There were test failures.
Interpreter: None (2.6.6-final-0)
Architecture: Darwin (32-bit)

Interpreter 3: 🔴 There were test failures.
Interpreter: None (2.7.2-final-0)
Architecture: Darwin (32-bit)

Interpreter 4: 🔴 There were test failures.
Interpreter: /sw/bin//python2.6 (2.6.8-final-0)
Architecture: Darwin (64-bit)

Interpreter 5: 🔴 There were test failures.
Interpreter: /sw/bin//python2.7 (2.7.3-final-0)
Architecture: Darwin (64-bit)

Interpreter 6: 🔴 There were test failures.
Interpreter: None (3.2.2-final-0)
Architecture: Darwin (32-bit)

Interpreter 7: 🔴 There were test failures.
Interpreter: None (3.3.0-beta-1)
Architecture: Darwin (32-bit)

Interpreter 8: 🔴 There were test failures.
Interpreter: /sw/bin//python3.2 (3.2.3-final-0)
Architecture: Darwin (64-bit)

Interpreter 9: 🔴 There were test failures.
Interpreter: None (3.3.0-beta-1)
Architecture: Darwin (64-bit)

Build HTML Docs: 🔴 There were test failures.
Sphinx version: 1.1.3

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 11, 2012

This pull request fails (merged c3964eb2 into 65b6582).

travisbot commented Aug 11, 2012

This pull request fails (merged c3964eb2 into 65b6582).

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov Aug 11, 2012

Member

SymPy Bot Summary: 🔴 There were test failures.

@catchmrbharath: Please fix the test failures.

Test command: setup.py test
master hash: b0a9866
branch hash: c3964eb2aca5d5a9a60dd2d5869e92135cb64ba2

Interpreter 1: 🔴 There were test failures.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY8KMjDA

Interpreter 2: 🔴 There were test failures.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYoMYiDA

Interpreter 3: 🔴 There were test failures.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYsfAhDA

Build HTML Docs: ✳️ All tests have passed.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYn8YiDA

Automatic review by SymPy Bot.

Member

Krastanov commented Aug 11, 2012

SymPy Bot Summary: 🔴 There were test failures.

@catchmrbharath: Please fix the test failures.

Test command: setup.py test
master hash: b0a9866
branch hash: c3964eb2aca5d5a9a60dd2d5869e92135cb64ba2

Interpreter 1: 🔴 There were test failures.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY8KMjDA

Interpreter 2: 🔴 There were test failures.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYoMYiDA

Interpreter 3: 🔴 There were test failures.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYsfAhDA

Build HTML Docs: ✳️ All tests have passed.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYn8YiDA

Automatic review by SymPy Bot.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 12, 2012

This pull request fails (merged 749e5664 into 65b6582).

travisbot commented Aug 12, 2012

This pull request fails (merged 749e5664 into 65b6582).

@catchmrbharath

This comment has been minimized.

Show comment
Hide comment
@catchmrbharath

catchmrbharath Aug 12, 2012

Contributor

@asmeurer @Krastanov Can you have a look at this? Is the API access better?

I will add the depth and the nb_of_points in an hour.

Contributor

catchmrbharath commented Aug 12, 2012

@asmeurer @Krastanov Can you have a look at this? Is the API access better?

I will add the depth and the nb_of_points in an hour.

@asmeurer

View changes

Show outdated Hide outdated sympy/plotting/plot.py
Multiple plots with same range.
plot_line(expr1, expr2, ..., range)
Multiple plots with different .

This comment has been minimized.

@asmeurer

asmeurer Aug 12, 2012

Member

ranges

@asmeurer

asmeurer Aug 12, 2012

Member

ranges

@asmeurer

View changes

Show outdated Hide outdated sympy/plotting/plot.py
Usage
=====
Single plot
plot3D_parametric(expr_x, expr_y, expr_z, range, kwargs)

This comment has been minimized.

@asmeurer

asmeurer Aug 12, 2012

Member

**kwargs

@asmeurer

asmeurer Aug 12, 2012

Member

**kwargs

This comment has been minimized.

@asmeurer

asmeurer Aug 12, 2012

Member

Are multiple plots with the same range supported here too?

@asmeurer

asmeurer Aug 12, 2012

Member

Are multiple plots with the same range supported here too?

This comment has been minimized.

@catchmrbharath

catchmrbharath Aug 12, 2012

Contributor

No. I am not able to differentiate between tuple of expressions and tuple of ranges as both are of length 3.

@catchmrbharath

catchmrbharath Aug 12, 2012

Contributor

No. I am not able to differentiate between tuple of expressions and tuple of ranges as both are of length 3.

``ylim`` : tuple of two floats, denoting the y - axis limits.
Examples
========

This comment has been minimized.

@asmeurer

asmeurer Aug 12, 2012

Member

Put an empty line under all your header lines.

@asmeurer

asmeurer Aug 12, 2012

Member

Put an empty line under all your header lines.

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 12, 2012

Member

By the way, we need a Sphinx file for the new plotting module.

Member

asmeurer commented Aug 12, 2012

By the way, we need a Sphinx file for the new plotting module.

@asmeurer

View changes

Show outdated Hide outdated sympy/plotting/plot.py
Usage
=====
Single Plot
plot_line(expr, range, ...)

This comment has been minimized.

@asmeurer

asmeurer Aug 12, 2012

Member

I think ... should be replaced with **kwargs.

@asmeurer

asmeurer Aug 12, 2012

Member

I think ... should be replaced with **kwargs.

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 12, 2012

Member

Where the range is optional, the spec should read [, range].

Member

asmeurer commented Aug 12, 2012

Where the range is optional, the spec should read [, range].

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 12, 2012

This pull request fails (merged dea33703 into 65b6582).

travisbot commented Aug 12, 2012

This pull request fails (merged dea33703 into 65b6582).

@catchmrbharath

This comment has been minimized.

Show comment
Hide comment
@catchmrbharath

catchmrbharath Aug 12, 2012

Contributor

Where the range is optional, the spec should read [, range]

I didn't get it. Can you show with an example? Thanks.

Contributor

catchmrbharath commented Aug 12, 2012

Where the range is optional, the spec should read [, range]

I didn't get it. Can you show with an example? Thanks.

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov Aug 12, 2012

Member

SymPy Bot Summary: 🔴 There were test failures.

@catchmrbharath: Please fix the test failures.

Test command: setup.py test
master hash: b0a9866
branch hash: dea3370300d87c475356e6182911c876f77581b2

Interpreter 1: 🔴 There were test failures.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY248iDA

Interpreter 2: 🔴 There were test failures.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYjIAiDA

Interpreter 3: 🔴 There were test failures.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY3bYiDA

Build HTML Docs: ✳️ All tests have passed.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY-9UiDA

Automatic review by SymPy Bot.

Member

Krastanov commented Aug 12, 2012

SymPy Bot Summary: 🔴 There were test failures.

@catchmrbharath: Please fix the test failures.

Test command: setup.py test
master hash: b0a9866
branch hash: dea3370300d87c475356e6182911c876f77581b2

Interpreter 1: 🔴 There were test failures.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY248iDA

Interpreter 2: 🔴 There were test failures.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYjIAiDA

Interpreter 3: 🔴 There were test failures.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY3bYiDA

Build HTML Docs: ✳️ All tests have passed.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY-9UiDA

Automatic review by SymPy Bot.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 12, 2012

This pull request fails (merged d38f44ff into b0a9866).

travisbot commented Aug 12, 2012

This pull request fails (merged d38f44ff into b0a9866).

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 12, 2012

This pull request fails (merged d38f44ff into b0a9866).

travisbot commented Aug 12, 2012

This pull request fails (merged d38f44ff into b0a9866).

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov Aug 12, 2012

Member

SymPy Bot Summary: 🔴 There were test failures.

@catchmrbharath: Please fix the test failures.

Test command: setup.py test
master hash: b0a9866
branch hash: d38f44ff5b160ab13b66aa52d0b11372b15804db

Interpreter 1: 🔴 There were test failures.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYtPAhDA

Interpreter 2: 🔴 There were test failures.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYkfUiDA

Interpreter 3: 🔴 There were test failures.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYwowjDA

Build HTML Docs: ✳️ All tests have passed.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY_tUiDA

Automatic review by SymPy Bot.

Member

Krastanov commented Aug 12, 2012

SymPy Bot Summary: 🔴 There were test failures.

@catchmrbharath: Please fix the test failures.

Test command: setup.py test
master hash: b0a9866
branch hash: d38f44ff5b160ab13b66aa52d0b11372b15804db

Interpreter 1: 🔴 There were test failures.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYtPAhDA

Interpreter 2: 🔴 There were test failures.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYkfUiDA

Interpreter 3: 🔴 There were test failures.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYwowjDA

Build HTML Docs: ✳️ All tests have passed.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY_tUiDA

Automatic review by SymPy Bot.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 13, 2012

This pull request fails (merged a764547d into 9215c28).

travisbot commented Aug 13, 2012

This pull request fails (merged a764547d into 9215c28).

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov Aug 13, 2012

Member

SymPy Bot Summary: 🔴 There were test failures.

@catchmrbharath: Please fix the test failures.

Test command: setup.py test
master hash: 9215c28
branch hash: a764547dbd89b69d056ace82ffa204dc8ea2540a

Interpreter 1: 🔴 There were test failures.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY2qsjDA

Interpreter 2: 🔴 There were test failures.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY9aMjDA

Interpreter 3: 🔴 There were test failures.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY4LYiDA

Build HTML Docs: ✳️ All tests have passed.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYsLMjDA

Automatic review by SymPy Bot.

Member

Krastanov commented Aug 13, 2012

SymPy Bot Summary: 🔴 There were test failures.

@catchmrbharath: Please fix the test failures.

Test command: setup.py test
master hash: 9215c28
branch hash: a764547dbd89b69d056ace82ffa204dc8ea2540a

Interpreter 1: 🔴 There were test failures.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY2qsjDA

Interpreter 2: 🔴 There were test failures.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY9aMjDA

Interpreter 3: 🔴 There were test failures.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY4LYiDA

Build HTML Docs: ✳️ All tests have passed.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYsLMjDA

Automatic review by SymPy Bot.

@catchmrbharath

This comment has been minimized.

Show comment
Hide comment
@catchmrbharath

catchmrbharath Aug 15, 2012

Contributor

The new API is complete. I have added the tests and also updated the notebooks with the new functions

@asmeurer @Krastanov One of things I was not sure of was whether to delete the present plot function. There are very good cases of plot, for example, while plotting the solutions of equations, where we don't know whether the plot is going to be 3D or 2D. Any suggestions / discussion on whether it should be removed or not?

Contributor

catchmrbharath commented Aug 15, 2012

The new API is complete. I have added the tests and also updated the notebooks with the new functions

@asmeurer @Krastanov One of things I was not sure of was whether to delete the present plot function. There are very good cases of plot, for example, while plotting the solutions of equations, where we don't know whether the plot is going to be 3D or 2D. Any suggestions / discussion on whether it should be removed or not?

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 15, 2012

Member

I vote for removing it.

By the way, this can't be merged cleanly.

Member

asmeurer commented Aug 15, 2012

I vote for removing it.

By the way, this can't be merged cleanly.

@catchmrbharath

This comment has been minimized.

Show comment
Hide comment
@catchmrbharath

catchmrbharath Aug 15, 2012

Contributor

I will rebase it.

Contributor

catchmrbharath commented Aug 15, 2012

I will rebase it.

catchmrbharath added some commits Aug 7, 2012

New plot functions added
* ``plot_line`` plots 2D lines
* ``plot_parametric`` plots 2D parametric lines
* ``plot3D`` plots 3D plots of expression of 2 variables
* ``plot3D_parametric`` plots 3D parametric line plots
* ``plot3D_surface`` plots 3D surfaces defined by 2 parameters
Documentation changes
* Addressed the comments
* Added information about which keyword arguments belong to which
class
Documentation changes.
* Addressed the comments.
* Add more information about default range.
Added support for depth and nb_of_points
* depth - recursion depth for adaptive sampling
* adaptive - set to false, if uniform sampling is needed
* nb_of_points - number of points the range has to be uniformly sampled into.

Changes to the documentation
Removed the parameters that are not defined for 3D plots.
added tests for new plotting functions
* added a global variable _show in plot module, if set to False
doesn't plot the graph, by default. This can be used in tests
where we have just save the plots without showing.

* changed tests so that they use the new plotting functions.
Changed the notebook to use the new notebook.
* Removed all instances of plot
* Added examples for each plot_* function
@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 23, 2012

This pull request fails (merged a89958c into b52b7c3).

travisbot commented Aug 23, 2012

This pull request fails (merged a89958c into b52b7c3).

plotting docstrings added to the sphinx
* changes to comments so that they look nice on sphinx.
@catchmrbharath

This comment has been minimized.

Show comment
Hide comment
@catchmrbharath

catchmrbharath Aug 23, 2012

Contributor

@Krastanov Wont the names you suggested for 3D plots be too long?
@asmeurer I have added the docs to sphinx. Can you just look at it, and see whether I have done it right. Thanks.

Contributor

catchmrbharath commented Aug 23, 2012

@Krastanov Wont the names you suggested for 3D plots be too long?
@asmeurer I have added the docs to sphinx. Can you just look at it, and see whether I have done it right. Thanks.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 23, 2012

This pull request passes (merged 786fb8b into b52b7c3).

travisbot commented Aug 23, 2012

This pull request passes (merged 786fb8b into b52b7c3).

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 23, 2012

Member

There are some serious doctest failures here (pasting here in case I have to kill sympy-bot):

examples/advanced/fem.py[1] .                                               [OK]
examples/advanced/gibbs_phenomenon.py[2] ..                                 [OK]
Traceback (most recent call last):
  File "setup.py", line 280, in <module>
    classifiers = classifiers,
  File "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/distutils/core.py", line 152, in setup
    dist.run_commands()
  File "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/distutils/dist.py", line 975, in run_commands
    self.run_command(cmd)
  File "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/distutils/dist.py", line 995, in run_command
    cmd_obj.run()
  File "setup.py", line 173, in run
    sympy.utilities.runtests.run_all_tests()
  File "/private/var/folders/wc/dppcpmxs1tlb36nqcw853wkm0000gq/T/sympy-bot-tmpFUVigL/sympy/sympy/utilities/runtests.py", line 249, in run_all_tests
    if not doctest(*doctest_args, **doctest_kwargs):
  File "/private/var/folders/wc/dppcpmxs1tlb36nqcw853wkm0000gq/T/sympy-bot-tmpFUVigL/sympy/sympy/utilities/runtests.py", line 502, in doctest
    return not bool(_doctest(*paths, **kwargs))
  File "/private/var/folders/wc/dppcpmxs1tlb36nqcw853wkm0000gq/T/sympy-bot-tmpFUVigL/sympy/sympy/utilities/runtests.py", line 567, in _doctest
    failed = not t.test()
  File "/private/var/folders/wc/dppcpmxs1tlb36nqcw853wkm0000gq/T/sympy-bot-tmpFUVigL/sympy/sympy/utilities/runtests.py", line 963, in test
    self.test_file(f)
  File "/private/var/folders/wc/dppcpmxs1tlb36nqcw853wkm0000gq/T/sympy-bot-tmpFUVigL/sympy/sympy/utilities/runtests.py", line 986, in test_file
    module = pdoctest._normalize_module(module)
  File "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/doctest.py", line 203, in _normalize_module
    return __import__(module, globals(), locals(), ["*"])
  File "/private/var/folders/wc/dppcpmxs1tlb36nqcw853wkm0000gq/t/sympy-bot-tmpfuvigl/sympy/examples/beginner/plot_examples.py", line 15, in <module>
    b = plot(expr, (x, 2, 4), show=False) # cartesian plot
TypeError: 'module' object is not callable
Member

asmeurer commented Aug 23, 2012

There are some serious doctest failures here (pasting here in case I have to kill sympy-bot):

examples/advanced/fem.py[1] .                                               [OK]
examples/advanced/gibbs_phenomenon.py[2] ..                                 [OK]
Traceback (most recent call last):
  File "setup.py", line 280, in <module>
    classifiers = classifiers,
  File "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/distutils/core.py", line 152, in setup
    dist.run_commands()
  File "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/distutils/dist.py", line 975, in run_commands
    self.run_command(cmd)
  File "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/distutils/dist.py", line 995, in run_command
    cmd_obj.run()
  File "setup.py", line 173, in run
    sympy.utilities.runtests.run_all_tests()
  File "/private/var/folders/wc/dppcpmxs1tlb36nqcw853wkm0000gq/T/sympy-bot-tmpFUVigL/sympy/sympy/utilities/runtests.py", line 249, in run_all_tests
    if not doctest(*doctest_args, **doctest_kwargs):
  File "/private/var/folders/wc/dppcpmxs1tlb36nqcw853wkm0000gq/T/sympy-bot-tmpFUVigL/sympy/sympy/utilities/runtests.py", line 502, in doctest
    return not bool(_doctest(*paths, **kwargs))
  File "/private/var/folders/wc/dppcpmxs1tlb36nqcw853wkm0000gq/T/sympy-bot-tmpFUVigL/sympy/sympy/utilities/runtests.py", line 567, in _doctest
    failed = not t.test()
  File "/private/var/folders/wc/dppcpmxs1tlb36nqcw853wkm0000gq/T/sympy-bot-tmpFUVigL/sympy/sympy/utilities/runtests.py", line 963, in test
    self.test_file(f)
  File "/private/var/folders/wc/dppcpmxs1tlb36nqcw853wkm0000gq/T/sympy-bot-tmpFUVigL/sympy/sympy/utilities/runtests.py", line 986, in test_file
    module = pdoctest._normalize_module(module)
  File "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/doctest.py", line 203, in _normalize_module
    return __import__(module, globals(), locals(), ["*"])
  File "/private/var/folders/wc/dppcpmxs1tlb36nqcw853wkm0000gq/t/sympy-bot-tmpfuvigl/sympy/examples/beginner/plot_examples.py", line 15, in <module>
    b = plot(expr, (x, 2, 4), show=False) # cartesian plot
TypeError: 'module' object is not callable
@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov Aug 24, 2012

If this was mentioned in docstrings it should get removed from them as well.

If this was mentioned in docstrings it should get removed from them as well.

also possible to plot 2-dimensional plots using a ``TextBackend`` if you don't
have ``Matplotlib``.
The plotting module has the following functions:

This comment has been minimized.

@Krastanov

Krastanov Aug 24, 2012

Member

Maybe say something about the fact that these functions are only for convenience and that the module is build around Series and Plot objects that can be called directly.

@Krastanov

Krastanov Aug 24, 2012

Member

Maybe say something about the fact that these functions are only for convenience and that the module is build around Series and Plot objects that can be called directly.

# TODO: Add color arrays for plots.
# TODO: Add more plotting options for 3d plots.
# TODO: Adaptive sampling for 3D plots.

This comment has been minimized.

@Krastanov

Krastanov Aug 24, 2012

Member

todo: contour plots (everything is already there, you can just copy/paste your new plot3d function and change the Series class)

@Krastanov

Krastanov Aug 24, 2012

Member

todo: contour plots (everything is already there, you can just copy/paste your new plot3d function and change the Series class)

Show outdated Hide outdated sympy/plotting/plot.py
Aesthetics
----------
``line_color``: float. Specifies the color for the plot.

This comment has been minimized.

@Krastanov

Krastanov Aug 24, 2012

Member

It is not a float, it is a function returning a float. Check the "coloring" example notebook. Another docstring already explains all this, just add in parentheses a reference to it (either Plot or Series).

@Krastanov

Krastanov Aug 24, 2012

Member

It is not a float, it is a function returning a float. Check the "coloring" example notebook. Another docstring already explains all this, just add in parentheses a reference to it (either Plot or Series).

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov Aug 24, 2012

Member

I think that there is a number of example notebooks that are still using the now nonexistent plot function.

The name that I suggested may indeed turn out to be too long, however I still find the present ones a bit confusing (maybe it is just be :)

Besides some minor corrections to the docstrings I think that they should be sufficient.

Member

Krastanov commented Aug 24, 2012

I think that there is a number of example notebooks that are still using the now nonexistent plot function.

The name that I suggested may indeed turn out to be too long, however I still find the present ones a bit confusing (maybe it is just be :)

Besides some minor corrections to the docstrings I think that they should be sufficient.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 24, 2012

This pull request passes (merged 6bfa913 into b52b7c3).

travisbot commented Aug 24, 2012

This pull request passes (merged 6bfa913 into b52b7c3).

catchmrbharath added some commits Aug 24, 2012

Renamed the plot functions
* plot_line -> plot
* plot3D -> plot3d
* plot3D_parametric -> plot3d_parametric_line
* plot3D_surface -> plot3d_parametric_surface
@catchmrbharath

This comment has been minimized.

Show comment
Hide comment
@catchmrbharath

catchmrbharath Aug 24, 2012

Contributor

I have changed the plot names.

  • plot_line -> plot
  • plot3D -> plot3d
  • plot3D_parametric -> plot3d_parametric_line
  • plot3D_surface -> plot3d_parametric_surface

@asmeurer I have also fixed the doctest failures and addressed @Krastanov comments.

Contributor

catchmrbharath commented Aug 24, 2012

I have changed the plot names.

  • plot_line -> plot
  • plot3D -> plot3d
  • plot3D_parametric -> plot3d_parametric_line
  • plot3D_surface -> plot3d_parametric_surface

@asmeurer I have also fixed the doctest failures and addressed @Krastanov comments.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 24, 2012

This pull request fails (merged 41466ca into b52b7c3).

travisbot commented Aug 24, 2012

This pull request fails (merged 41466ca into b52b7c3).

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov Aug 24, 2012

Member

I do not find any obvious issues anymore. Thanks for all the work.

Member

Krastanov commented Aug 24, 2012

I do not find any obvious issues anymore. Thanks for all the work.

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 24, 2012

Member

By the way, @catchmrbharath as noted on the mailing list, please refrain from rebasing this branch, so it can be merged into 0.7.2.

Member

asmeurer commented Aug 24, 2012

By the way, @catchmrbharath as noted on the mailing list, please refrain from rebasing this branch, so it can be merged into 0.7.2.

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 24, 2012

Member

SymPy Bot Summary: 🔴 Failed after merging catchmrbharath/restructured_plot (41466ca) into master (a184841).
@catchmrbharath: Please fix the test failures.
🔴 Python 2.5.0-final-0: fail
🔴 Python 2.6.6-final-0: fail
🔴 Python 2.7.2-final-0: fail
🔴 Python 2.6.8-final-0: fail
🔴 Python 2.7.3-final-0: fail
🔴 PyPy 1.9.0-final-0; 2.7.2-final-42: fail
✳️ Python 3.2.2-final-0: pass
✳️ Python 3.3.0-beta-2: pass
✳️ Python 3.2.3-final-0: pass
✳️ Python 3.3.0-beta-2: pass
🔴Sphinx 1.1.3: fail

Member

asmeurer commented Aug 24, 2012

SymPy Bot Summary: 🔴 Failed after merging catchmrbharath/restructured_plot (41466ca) into master (a184841).
@catchmrbharath: Please fix the test failures.
🔴 Python 2.5.0-final-0: fail
🔴 Python 2.6.6-final-0: fail
🔴 Python 2.7.2-final-0: fail
🔴 Python 2.6.8-final-0: fail
🔴 Python 2.7.3-final-0: fail
🔴 PyPy 1.9.0-final-0; 2.7.2-final-42: fail
✳️ Python 3.2.2-final-0: pass
✳️ Python 3.3.0-beta-2: pass
✳️ Python 3.2.3-final-0: pass
✳️ Python 3.3.0-beta-2: pass
🔴Sphinx 1.1.3: fail

@catchmrbharath

This comment has been minimized.

Show comment
Hide comment
@catchmrbharath

catchmrbharath Aug 24, 2012

Contributor

Sorry about that. Forgot to run quality test for the last commit. I will squash the new commit once all tests pass.

Contributor

catchmrbharath commented Aug 24, 2012

Sorry about that. Forgot to run quality test for the last commit. I will squash the new commit once all tests pass.

@catchmrbharath

This comment has been minimized.

Show comment
Hide comment
@catchmrbharath

catchmrbharath Aug 24, 2012

Contributor

I am not sure why the sphinx make is failing. It runs without a problem on my machine.

Contributor

catchmrbharath commented Aug 24, 2012

I am not sure why the sphinx make is failing. It runs without a problem on my machine.

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 24, 2012

Member

I think it is a failure from master.

Member

asmeurer commented Aug 24, 2012

I think it is a failure from master.

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 24, 2012

Member

I'm running the tests against 0.7.2 to see how things will be there.

Member

asmeurer commented Aug 24, 2012

I'm running the tests against 0.7.2 to see how things will be there.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 24, 2012

This pull request passes (merged 274ec3f into b52b7c3).

travisbot commented Aug 24, 2012

This pull request passes (merged 274ec3f into b52b7c3).

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 24, 2012

Member

SymPy Bot Summary: 🔴 Failed after merging catchmrbharath/restructured_plot (274ec3f) into origin/0.7.2 (c1c3b17).
@catchmrbharath: Please fix the test failures.
✳️ Python 2.5.0-final-0: pass
✳️ Python 2.6.6-final-0: pass
✳️ Python 2.7.2-final-0: pass
✳️ Python 2.6.8-final-0: pass
✳️ Python 2.7.3-final-0: pass
🔴 PyPy 1.9.0-final-0; 2.7.2-final-42: fail
✳️ Python 3.2.2-final-0: pass
✳️ Python 3.3.0-beta-2: pass
✳️ Python 3.2.3-final-0: pass
✳️ Python 3.3.0-beta-2: pass
🔴Sphinx 1.1.3: fail

Member

asmeurer commented Aug 24, 2012

SymPy Bot Summary: 🔴 Failed after merging catchmrbharath/restructured_plot (274ec3f) into origin/0.7.2 (c1c3b17).
@catchmrbharath: Please fix the test failures.
✳️ Python 2.5.0-final-0: pass
✳️ Python 2.6.6-final-0: pass
✳️ Python 2.7.2-final-0: pass
✳️ Python 2.6.8-final-0: pass
✳️ Python 2.7.3-final-0: pass
🔴 PyPy 1.9.0-final-0; 2.7.2-final-42: fail
✳️ Python 3.2.2-final-0: pass
✳️ Python 3.3.0-beta-2: pass
✳️ Python 3.2.3-final-0: pass
✳️ Python 3.3.0-beta-2: pass
🔴Sphinx 1.1.3: fail

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 24, 2012

Member

OK, those Sphinx errors you do need to fix.

Member

asmeurer commented Aug 24, 2012

OK, those Sphinx errors you do need to fix.

@catchmrbharath

This comment has been minimized.

Show comment
Hide comment
@catchmrbharath

catchmrbharath Aug 25, 2012

Contributor

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY6eYkDA

Interpreter: /usr/local/bin/python (2.7.3-final-0)
Architecture: Darwin (64-bit)
Cache: yes
Test command: setup.py test
master hash: a184841
branch hash: 274ec3f

Automatic review by SymPy Bot.

Contributor

catchmrbharath commented Aug 25, 2012

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY6eYkDA

Interpreter: /usr/local/bin/python (2.7.3-final-0)
Architecture: Darwin (64-bit)
Cache: yes
Test command: setup.py test
master hash: a184841
branch hash: 274ec3f

Automatic review by SymPy Bot.

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 25, 2012

Member

SymPy Bot Summary: 🔴 Failed after merging catchmrbharath/restructured_plot (6478b79) into origin/0.7.2 (c1c3b17).
@catchmrbharath: Please fix the test failures.
🔴Sphinx 1.1.3: fail

Member

asmeurer commented Aug 25, 2012

SymPy Bot Summary: 🔴 Failed after merging catchmrbharath/restructured_plot (6478b79) into origin/0.7.2 (c1c3b17).
@catchmrbharath: Please fix the test failures.
🔴Sphinx 1.1.3: fail

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 25, 2012

Member

SymPy Bot Summary: 🔴 Failed after merging catchmrbharath/restructured_plot (6478b79) into HEAD (6478b79).
@catchmrbharath: Please fix the test failures.
🔴Sphinx 1.1.3: fail

Member

asmeurer commented Aug 25, 2012

SymPy Bot Summary: 🔴 Failed after merging catchmrbharath/restructured_plot (6478b79) into HEAD (6478b79).
@catchmrbharath: Please fix the test failures.
🔴Sphinx 1.1.3: fail

@catchmrbharath

This comment has been minimized.

Show comment
Hide comment
@catchmrbharath

catchmrbharath Aug 25, 2012

Contributor

SymPy Bot Summary: 🔴 Failed after merging catchmrbharath/restructured_plot (6478b79) into master (a184841).
@catchmrbharath: Please fix the test failures.
🔴Sphinx 1.1.3: fail

Contributor

catchmrbharath commented Aug 25, 2012

SymPy Bot Summary: 🔴 Failed after merging catchmrbharath/restructured_plot (6478b79) into master (a184841).
@catchmrbharath: Please fix the test failures.
🔴Sphinx 1.1.3: fail

@catchmrbharath

This comment has been minimized.

Show comment
Hide comment
@catchmrbharath

catchmrbharath Aug 25, 2012

Contributor

SymPy Bot Summary: 🔴 Failed after merging catchmrbharath/restructured_plot (6478b79) into master (a184841).
@catchmrbharath: Please fix the test failures.
🔴Sphinx 1.1.3: fail

Contributor

catchmrbharath commented Aug 25, 2012

SymPy Bot Summary: 🔴 Failed after merging catchmrbharath/restructured_plot (6478b79) into master (a184841).
@catchmrbharath: Please fix the test failures.
🔴Sphinx 1.1.3: fail

asmeurer added a commit that referenced this pull request Aug 25, 2012

Merge pull request #1468 from catchmrbharath/restructured_plot
[Work in Progress] Basic framework for restructured plot.

@asmeurer asmeurer merged commit 5b149c2 into sympy:master Aug 25, 2012

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 30, 2013

Coverage Status

Changes Unknown when pulling 6478b79 on catchmrbharath:restructured_plot into * on sympy:master*.

coveralls commented Oct 30, 2013

Coverage Status

Changes Unknown when pulling 6478b79 on catchmrbharath:restructured_plot into * on sympy:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment